Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281836

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

From Michael Wang <yun.wang@profitbricks.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak
Date 2015-12-02 15:10 +0100
Message-ID <qBggA-8db-59@gated-at.bofh.it> (permalink)
References (6 earlier) <qBfua-7Ey-7@gated-at.bofh.it> <qBfua-7Ey-5@gated-at.bofh.it> <qBfXc-7QB-27@gated-at.bofh.it> <qBfXc-7QB-25@gated-at.bofh.it> <qBg6S-7Ug-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 12/02/2015 02:59 PM, Borislav Petkov wrote:
> On Wed, Dec 02, 2015 at 02:48:47PM +0100, Michael Wang wrote:
>> I'm not sure why amd-iommu use get_page not kmalloc to initialize the
>> pointer table, but if it's necessary then the conflict will be there,
>> it's not the fault of driver or kmemleak, but the design require them
>> to cooperate with each other.
> 
> So, according to you, we should go and "fix" all callers of
> __get_free_pages() to make kmemleak happy. Then when the next new tool
> comes along, we should "fix" another kernel API just so that the tools
> are happy.

That's the way we have to detect leak, no driver could get rid of
the possibility of memory leaking, so it should respect the rule to
help others locating the problem, if a driver full of false report then
most likely folks will gradually lost interests on help fix leaking
problem for it.

> 
> Bzzt. Wrong!
> 
> The tools should work without sprinkling their code everywhere. Driver
> etc developers don't need to care about what tool they make happy or
> not. Tools' hooks should be hidden in macro magic so that developers
> don't care.

This tool will help improve the kernel, AFAIK it's already made it's
best, if you got any idea on how to make it even better that would be
great, but at this moment, it still need few of care :-P

Regards,
Michael Wang

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 11:40 +0100
  Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 12:00 +0100
    Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 12:40 +0100
      Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 13:00 +0100
        Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 13:40 +0100
          Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 14:00 +0100
            Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:10 +0100
          Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:00 +0100
            Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:10 +0100
              Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:20 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:50 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 15:00 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 15:10 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 15:20 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 15:30 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 18:40 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 19:50 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-03 09:50 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:50 +0100
              Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:20 +0100
    Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 12:40 +0100
  Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 12:00 +0100
    Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 12:20 +0100

csiph-web