Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281622
| From | Michael Wang <yun.wang@profitbricks.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak |
| Date | 2015-12-02 12:00 +0100 |
| Message-ID | <qBdiF-64Q-1@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <qwScO-6B6-7@gated-at.bofh.it> <qyJRL-7Wr-1@gated-at.bofh.it> <qyK1s-7ZU-33@gated-at.bofh.it> <qBcZk-5WX-7@gated-at.bofh.it> <qBdiF-64Q-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/02/2015 11:52 AM, Catalin Marinas wrote:
[snip]
>>
>> Is there any more concern? actually we just want to get rid of this
>> annoying report on obj won't leak, if you're going to create obj for
>> 'irq_lookup_table' that's also fine for us, or will you pick this patch?
>
> My preference (from a kmemleak perspective) is to tell kmemleak about
> the irq_lookup_table. Untested:
I'm fine with both solution, will leave the decision to maintainer :-)
BTW, could you please send a formal patch with descriptions?
Regards,
Michael Wang
>
> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> index 013bdfff2d4d..c41609f71cbe 100644
> --- a/drivers/iommu/amd_iommu_init.c
> +++ b/drivers/iommu/amd_iommu_init.c
> @@ -27,6 +27,7 @@
> #include <linux/amd-iommu.h>
> #include <linux/export.h>
> #include <linux/iommu.h>
> +#include <linux/kmemleak.h>
> #include <asm/pci-direct.h>
> #include <asm/iommu.h>
> #include <asm/gart.h>
> @@ -1692,6 +1693,7 @@ static struct syscore_ops amd_iommu_syscore_ops = {
>
> static void __init free_on_init_error(void)
> {
> + kmemleak_free(irq_lookup_table);
> free_pages((unsigned long)irq_lookup_table,
> get_order(rlookup_table_size));
>
> @@ -1906,6 +1908,7 @@ static int __init early_amd_iommu_init(void)
> irq_lookup_table = (void *)__get_free_pages(
> GFP_KERNEL | __GFP_ZERO,
> get_order(rlookup_table_size));
> + kmemleak_alloc(irq_lookup_table, rlookup_table_size, 1, GFP_KERNEL);
> if (!irq_lookup_table)
> goto out;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 11:40 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 12:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 12:40 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 13:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 13:40 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 14:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:10 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:10 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:20 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:50 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 15:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 15:10 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 15:20 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 15:30 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 18:40 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 19:50 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-03 09:50 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:50 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:20 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 12:40 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 12:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 12:20 +0100
csiph-web