Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

From	Michael Wang <yun.wang@profitbricks.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak
Date	2015-12-02 11:40 +0100
Message-ID	<qBcZk-5WX-7@gated-at.bofh.it> (permalink)
References	<qwRJL-6qF-5@gated-at.bofh.it> <qwScO-6B6-7@gated-at.bofh.it> <qyJRL-7Wr-1@gated-at.bofh.it> <qyK1s-7ZU-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Joerg

On 11/25/2015 04:14 PM, Michael Wang wrote:
> On 11/25/2015 04:08 PM, Joerg Roedel wrote:
[snip]
>>> This is caused by the 'irq_lookup_table' was allocated with
>>> __get_free_pages() which won't create kmemleak object, thus it's
>>> pointers won't be count as referencing 'irq_remap_table' in
>>> kmemleak scan.
>>
>> Isn't it better to allocate the kmemleak object manually instead of
>> ignoring all irq-table pointers? With this patch we might not notice any
>> real leak of irq-tables.
> 
> We've considered that too, but found that the irq-tables is not
> dynamically alloc/free, they won't be freed once initialized, so there
> is no leaking for such object :-)

Is there any more concern? actually we just want to get rid of this
annoying report on obj won't leak, if you're going to create obj for
'irq_lookup_table' that's also fine for us, or will you pick this patch?

Regards,
Michael Wang

> 
> Regards,
> Michael Wang
> 
>>
>>
>>
>> 	Joerg
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 11:40 +0100
  Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 12:00 +0100
    Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 12:40 +0100
      Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 13:00 +0100
        Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 13:40 +0100
          Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 14:00 +0100
            Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:10 +0100
          Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:00 +0100
            Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:10 +0100
              Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:20 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:50 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 15:00 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 15:10 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 15:20 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 15:30 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 18:40 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 19:50 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-03 09:50 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:50 +0100
              Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:20 +0100
    Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 12:40 +0100
  Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 12:00 +0100
    Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 12:20 +0100

csiph-web