Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281789

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

From Michael Wang <yun.wang@profitbricks.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak
Date 2015-12-02 14:50 +0100
Message-ID <qBfXc-7QB-25@gated-at.bofh.it> (permalink)
References (6 earlier) <qBfaO-7ik-27@gated-at.bofh.it> <qBfku-7B5-21@gated-at.bofh.it> <qBfua-7Ey-7@gated-at.bofh.it> <qBfua-7Ey-5@gated-at.bofh.it> <qBfXc-7QB-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 12/02/2015 02:40 PM, Borislav Petkov wrote:
> On Wed, Dec 02, 2015 at 02:18:44PM +0100, Michael Wang wrote:
[snip]
> 
>> Yeah, but it would be better to solve it, otherwise whoever saw this
>> report will need to go into the amd-iommu, make sure it's not a real
>> leak, then change their testing script...
> 
> No, you don't need to go into the iommu - you need to fix kmemleak.
> 
> And frankly, I'm getting sick and tired of all those tools needing
> special handling and us adding code just so that they're happy. If the
> tools can't figure out something, they shouldn't warn just in case but
> shut up instead.

If you mean the design of kmemleak, IMHO it's not that bad.

The problem is regarding performance, think about if kmemleak go into
every page to find out pointers, I guess the whole system will stuck.

I'm not sure why amd-iommu use get_page not kmalloc to initialize the pointer
table, but if it's necessary then the conflict will be there, it's not the fault
of driver or kmemleak, but the design require them to cooperate with each
other.

Regards,
Michael Wang

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 11:40 +0100
  Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 12:00 +0100
    Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 12:40 +0100
      Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 13:00 +0100
        Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 13:40 +0100
          Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 14:00 +0100
            Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:10 +0100
          Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:00 +0100
            Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:10 +0100
              Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:20 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:50 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 15:00 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 15:10 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 15:20 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 15:30 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 18:40 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 19:50 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-03 09:50 +0100
                Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:50 +0100
              Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:20 +0100
    Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 12:40 +0100
  Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 12:00 +0100
    Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for  kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 12:20 +0100

csiph-web