Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281810
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak |
| Date | 2015-12-02 15:00 +0100 |
| Message-ID | <qBg6S-7Ug-9@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <qBfku-7B5-21@gated-at.bofh.it> <qBfua-7Ey-7@gated-at.bofh.it> <qBfua-7Ey-5@gated-at.bofh.it> <qBfXc-7QB-27@gated-at.bofh.it> <qBfXc-7QB-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Dec 02, 2015 at 02:48:47PM +0100, Michael Wang wrote:
> I'm not sure why amd-iommu use get_page not kmalloc to initialize the
> pointer table, but if it's necessary then the conflict will be there,
> it's not the fault of driver or kmemleak, but the design require them
> to cooperate with each other.
So, according to you, we should go and "fix" all callers of
__get_free_pages() to make kmemleak happy. Then when the next new tool
comes along, we should "fix" another kernel API just so that the tools
are happy.
Bzzt. Wrong!
The tools should work without sprinkling their code everywhere. Driver
etc developers don't need to care about what tool they make happy or
not. Tools' hooks should be hidden in macro magic so that developers
don't care.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 11:40 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 12:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 12:40 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 13:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 13:40 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 14:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:10 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:10 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:20 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 14:50 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 15:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 15:10 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 15:20 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-02 15:30 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 18:40 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 19:50 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang <yun.wang@profitbricks.com> - 2015-12-03 09:50 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:50 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Borislav Petkov <bp@alien8.de> - 2015-12-02 14:20 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 12:40 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Catalin Marinas <catalin.marinas@gmail.com> - 2015-12-02 12:00 +0100
Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Joerg Roedel <joro@8bytes.org> - 2015-12-02 12:20 +0100
csiph-web