Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1206553

Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

From Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
Date 2015-08-13 09:20 +0200
Message-ID <pWUXU-4He-15@gated-at.bofh.it> (permalink)
References <pWOz8-3Go-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello,

On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote:
> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> changes the prototype of devm_gpiod_get_optional() API which should include
> the falgs mandatory.
I'd write: "With commit b17d1bf16cc7 ("...") it becomes necessary to
pass the flags argument." After all it is possible (and recommended)
already now to use it. Your wording sounds as if b17d1bf16cc7 changed
the API in an incompatible way.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 02:30 +0200
  Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Roger Quadros <rogerq@ti.com> - 2015-08-13 09:10 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Roger Quadros <rogerq@ti.com> - 2015-08-13 09:30 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 09:30 +0200
  Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-08-13 09:20 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 10:20 +0200

csiph-web