Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1206439 > unrolled thread

[PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

Started byChanwoo Choi <cw00.choi@samsung.com>
First post2015-08-13 02:30 +0200
Last post2015-08-13 10:20 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 02:30 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Roger Quadros <rogerq@ti.com> - 2015-08-13 09:10 +0200
      Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Roger Quadros <rogerq@ti.com> - 2015-08-13 09:30 +0200
      Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 09:30 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-08-13 09:20 +0200
      Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 10:20 +0200

#1206439 — [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

FromChanwoo Choi <cw00.choi@samsung.com>
Date2015-08-13 02:30 +0200
Subject[PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
Message-ID<pWOz8-3Go-15@gated-at.bofh.it>
Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
changes the prototype of devm_gpiod_get_optional() API which should include
the falgs mandatory.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/extcon/extcon-palmas.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 662e91778cb0..308928d44ead 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
 			palmas_usb->wakeup = pdata->wakeup;
 	}
 
-	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
+	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
+							GPIOD_IN);
 	if (IS_ERR(palmas_usb->id_gpiod)) {
 		dev_err(&pdev->dev, "failed to get id gpio\n");
 		return PTR_ERR(palmas_usb->id_gpiod);
-- 
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1206547

FromRoger Quadros <rogerq@ti.com>
Date2015-08-13 09:10 +0200
Message-ID<pWUOd-4vH-9@gated-at.bofh.it>
In reply to#1206439
Hi Chanwoo,

On 13/08/15 03:29, Chanwoo Choi wrote:
> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> changes the prototype of devm_gpiod_get_optional() API which should include
> the falgs mandatory.

s/falgs/flags

> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/extcon/extcon-palmas.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 662e91778cb0..308928d44ead 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  			palmas_usb->wakeup = pdata->wakeup;
>  	}
>  
> -	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> +	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
> +							GPIOD_IN);
>  	if (IS_ERR(palmas_usb->id_gpiod)) {
>  		dev_err(&pdev->dev, "failed to get id gpio\n");
>  		return PTR_ERR(palmas_usb->id_gpiod);
> 

Can you please include the following headers in this patch?

#include <linux/gpio.h>
#include <linux/gpio/consumer.h>

This should fix the randconfig build errors reported by Jim Davis at
http://article.gmane.org/gmane.linux.kernel/2018960

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1206561

FromRoger Quadros <rogerq@ti.com>
Date2015-08-13 09:30 +0200
Message-ID<pWV7A-4Ss-19@gated-at.bofh.it>
In reply to#1206547
On 13/08/15 10:24, Chanwoo Choi wrote:
> 
> On 08/13/2015 04:06 PM, Roger Quadros wrote:
>> Hi Chanwoo,
>>
>> On 13/08/15 03:29, Chanwoo Choi wrote:
>>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>>> changes the prototype of devm_gpiod_get_optional() API which should include
>>> the falgs mandatory.
>>
>> s/falgs/flags
>>
>>>
>>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> ---
>>>  drivers/extcon/extcon-palmas.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
>>> index 662e91778cb0..308928d44ead 100644
>>> --- a/drivers/extcon/extcon-palmas.c
>>> +++ b/drivers/extcon/extcon-palmas.c
>>> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>>>  			palmas_usb->wakeup = pdata->wakeup;
>>>  	}
>>>  
>>> -	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
>>> +	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
>>> +							GPIOD_IN);
>>>  	if (IS_ERR(palmas_usb->id_gpiod)) {
>>>  		dev_err(&pdev->dev, "failed to get id gpio\n");
>>>  		return PTR_ERR(palmas_usb->id_gpiod);
>>>
>>
>> Can you please include the following headers in this patch?
>>
>> #include <linux/gpio.h>
>> #include <linux/gpio/consumer.h>
> 
> I think that extcon-palmas need only "#include <linux/gpio/consumer.h>"
> because of of_gpio.h file already include the gpio.h.

OK with me.

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1206562 — Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

FromChanwoo Choi <cw00.choi@samsung.com>
Date2015-08-13 09:30 +0200
SubjectRe: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
Message-ID<pWV7A-4Ss-9@gated-at.bofh.it>
In reply to#1206547
On 08/13/2015 04:06 PM, Roger Quadros wrote:
> Hi Chanwoo,
> 
> On 13/08/15 03:29, Chanwoo Choi wrote:
>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>> changes the prototype of devm_gpiod_get_optional() API which should include
>> the falgs mandatory.
> 
> s/falgs/flags
> 
>>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>  drivers/extcon/extcon-palmas.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
>> index 662e91778cb0..308928d44ead 100644
>> --- a/drivers/extcon/extcon-palmas.c
>> +++ b/drivers/extcon/extcon-palmas.c
>> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>>  			palmas_usb->wakeup = pdata->wakeup;
>>  	}
>>  
>> -	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
>> +	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
>> +							GPIOD_IN);
>>  	if (IS_ERR(palmas_usb->id_gpiod)) {
>>  		dev_err(&pdev->dev, "failed to get id gpio\n");
>>  		return PTR_ERR(palmas_usb->id_gpiod);
>>
> 
> Can you please include the following headers in this patch?
> 
> #include <linux/gpio.h>
> #include <linux/gpio/consumer.h>

I think that extcon-palmas need only "#include <linux/gpio/consumer.h>"
because of of_gpio.h file already include the gpio.h.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1206553 — Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

FromUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date2015-08-13 09:20 +0200
SubjectRe: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
Message-ID<pWUXU-4He-15@gated-at.bofh.it>
In reply to#1206439
Hello,

On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote:
> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> changes the prototype of devm_gpiod_get_optional() API which should include
> the falgs mandatory.
I'd write: "With commit b17d1bf16cc7 ("...") it becomes necessary to
pass the flags argument." After all it is possible (and recommended)
already now to use it. Your wording sounds as if b17d1bf16cc7 changed
the API in an incompatible way.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1206593 — Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

FromChanwoo Choi <cw00.choi@samsung.com>
Date2015-08-13 10:20 +0200
SubjectRe: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
Message-ID<pWVTX-625-9@gated-at.bofh.it>
In reply to#1206553
On 08/13/2015 04:14 PM, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote:
>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>> changes the prototype of devm_gpiod_get_optional() API which should include
>> the falgs mandatory.
> I'd write: "With commit b17d1bf16cc7 ("...") it becomes necessary to
> pass the flags argument." After all it is possible (and recommended)
> already now to use it. Your wording sounds as if b17d1bf16cc7 changed
> the API in an incompatible way.

OK, I'll modify the patch description by using your recommened sentence.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web