Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1206593

Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

Show all headers | View raw

On 08/13/2015 04:14 PM, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote:
>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>> changes the prototype of devm_gpiod_get_optional() API which should include
>> the falgs mandatory.
> I'd write: "With commit b17d1bf16cc7 ("...") it becomes necessary to
> pass the flags argument." After all it is possible (and recommended)
> already now to use it. Your wording sounds as if b17d1bf16cc7 changed
> the API in an incompatible way.

OK, I'll modify the patch description by using your recommened sentence.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 02:30 +0200
  Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Roger Quadros <rogerq@ti.com> - 2015-08-13 09:10 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Roger Quadros <rogerq@ti.com> - 2015-08-13 09:30 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 09:30 +0200
  Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-08-13 09:20 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 10:20 +0200

csiph-web