Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1206439

[PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

Show all headers | View raw

Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
changes the prototype of devm_gpiod_get_optional() API which should include
the falgs mandatory.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/extcon/extcon-palmas.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 662e91778cb0..308928d44ead 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
 			palmas_usb->wakeup = pdata->wakeup;
 	}
 
-	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
+	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
+							GPIOD_IN);
 	if (IS_ERR(palmas_usb->id_gpiod)) {
 		dev_err(&pdev->dev, "failed to get id gpio\n");
 		return PTR_ERR(palmas_usb->id_gpiod);
-- 
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 02:30 +0200
  Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Roger Quadros <rogerq@ti.com> - 2015-08-13 09:10 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional  API change Roger Quadros <rogerq@ti.com> - 2015-08-13 09:30 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 09:30 +0200
  Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-08-13 09:20 +0200
    Re: [PATCH] extcon: palmas: Fix build break due to  devm_gpiod_get_optional API change Chanwoo Choi <cw00.choi@samsung.com> - 2015-08-13 10:20 +0200

csiph-web