Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #12491

Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1 [ITP]]

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Thomas,

Thanks for the review, and it's nice to see you found a number of 
problems! I have to admit I did not prepare a new package since a long 
time, probably forgot a lot of things, and copied others from other 
packages of mine...

On 2020-04-19 14:09+0200, Thomas Goirand wrote:
>Hi Felix,
>
>Thanks for working on this. Here's my comments. I'm sorry that there's a
>lot to say on what you did... :/
>
>On 4/19/20 11:53 AM, Félix Sipma wrote:
>>  dget -x  	https://mentors.debian.net/debian/pool/main/s/sphinx-autoapi/sphinx-autoapi_1.2.1-1.dsc
>
>Looking at your debian/copyright, I'd strongly suggest releasing the
>Debian packaging under the same license. For me that's a blocker for
>sponsoring the package (it may be ok for others to sponsor).

OK. I prefer using GPL-3+, but nevermind, I would really like to get
this package in sid soon. Other sponsors are still to be found, so I 
turned it to Expat.

>You wrote in d/control as if the 2nd line of Description: was the
>continuation of the short description. This is not the case. Please
>write a proper short description (ie: the first line after
>"Description:") and a long description (what goes after that first line)
>as *not* the continuation of the first line. It's very much ok to repeat
>the short description in the long one. This is also a blocker for me to
>sponsor the package.

Sorry about this, I guess I wanted to write a small description, forgot 
about it, and just put the long description instead. It should be fixed 
now.

>You're packaging the doc "as-is" without using Sphinx to build it. Any
>reason why, or you just don't know how yet? :) I'd suggest looking at
>other Python package building a -doc package to fix this. I'd also
>suggest packaging the doc in a separate -doc package.

Woops, I guess I didn't look closely to the build logs... And I did this 
for a package used for generating doc: I should be punished for that :).

>Also, please remove:
>
>[import-orig]
>merge-mode = replace
>
>from debian/gbp.conf. This is typically something that goes into
>~/.gbp.conf rather than on individual packages.

I don't agree with you on this one. To me, this kind of setting should 
be put in the package, to have an uniform way of updating/building/etc. 
a given package, whoever the uploader could be.

>Can you explain in more details than in debian/rules why you're
>overriding override_dh_auto_clean ? What does it try to download, apart
>from the build dependencies? Can't you set $clean_source = 0; in your
>~/.sbuildrc instead?

Mmh, I don't remember about this... I probably copied it from another of 
my packages, without looking at it. It works without, so I removed it. 
I'll try to find what this other package is to see if I can fix it 
properly :-).

Note that I found and patched another access to the internet during 
build (see 0001-Use-local-object-inventory-files-for-sphinx.patch).

More generally, I disagree with needing special settings in ~/.sbuildrc 
(or other user configuration, or special command line arguments) before 
updating a package. I think that is just making life harder for 
(potential) future uploaders.

>I hope this helps,

Sure, thanks! I have to say that I was starting filling quite 
demotivated because of not finding a sponsor for this little package... 
(And I have the same issue for other haskell packages, maybe I should 
finally complete the procedure to apply for becoming a DD...). I hope I 
fixed the issues you found and that you will agree with my argument for 
the debian/gbp.conf setting.

The new package is at https://mentors.debian.net/debian/pool/main/s/sphinx-autoapi/sphinx-autoapi_1.3.0-1.dsc

Regards,

-- 
Félix

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1  [ITP]] Félix Sipma <felix+debian@gueux.org> - 2020-04-19 12:10 +0200
  Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1  [ITP]] Félix Sipma <felix+debian@gueux.org> - 2020-04-19 17:30 +0200
    Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1 [ITP]] Scott Kitterman <debian@kitterman.com> - 2020-04-19 17:40 +0200
      Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1  [ITP]] Félix Sipma <felix+debian@gueux.org> - 2020-04-19 19:00 +0200
    Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1  [ITP]] Dmitry Shachnev <mitya57@debian.org> - 2020-04-19 22:20 +0200
      Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1  [ITP]] Félix Sipma <felix+debian@gueux.org> - 2020-04-20 11:20 +0200
    Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1  [ITP]] Félix Sipma <felix+debian@gueux.org> - 2020-04-20 11:20 +0200
      Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1  [ITP]] Félix Sipma <felix+debian@gueux.org> - 2020-04-20 14:50 +0200
        Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1  [ITP]] Félix Sipma <felix+debian@gueux.org> - 2020-04-20 16:40 +0200
          Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1  [ITP]] Félix Sipma <felix+debian@gueux.org> - 2020-04-21 11:20 +0200

csiph-web