Path: csiph.com!4.us.feeder.erje.net!3.eu.feeder.erje.net!feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From: =?utf-8?B?RsOpbGl4?= Sipma <felix+debian@gueux.org>
Newsgroups: linux.debian.maint.python
Subject: Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1  [ITP]]
Date: Sun, 19 Apr 2020 17:30:02 +0200
Message-ID: <zXk3n-893-5@gated-at.bofh.it>
References: <zXf3I-4Ut-13@gated-at.bofh.it> <zXk3o-893-7@gated-at.bofh.it>
Old-Return-Path: <felix+debian@gueux.org>
Mail-Followup-To: Thomas Goirand <zigo@debian.org>, debian-python@lists.debian.org
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mP3DRpeJDSE+ciuQ"
Content-Disposition: inline
Approved: robomod@news.nic.it
Lines: 110
Organization: linux.* mail to news gateway
Sender: robomod@news.nic.it
Xref: csiph.com linux.debian.maint.python:12491


--mP3DRpeJDSE+ciuQ
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Thomas,

Thanks for the review, and it's nice to see you found a number of=20
problems! I have to admit I did not prepare a new package since a long=20
time, probably forgot a lot of things, and copied others from other=20
packages of mine...

On 2020-04-19 14:09+0200, Thomas Goirand wrote:
>Hi Felix,
>
>Thanks for working on this. Here's my comments. I'm sorry that there's a
>lot to say on what you did... :/
>
>On 4/19/20 11:53 AM, F=C3=A9lix Sipma wrote:
>>  dget -x  	https://mentors.debian.net/debian/pool/main/s/sphinx-autoapi/=
sphinx-autoapi_1.2.1-1.dsc
>
>Looking at your debian/copyright, I'd strongly suggest releasing the
>Debian packaging under the same license. For me that's a blocker for
>sponsoring the package (it may be ok for others to sponsor).

OK. I prefer using GPL-3+, but nevermind, I would really like to get
this package in sid soon. Other sponsors are still to be found, so I=20
turned it to Expat.

>You wrote in d/control as if the 2nd line of Description: was the
>continuation of the short description. This is not the case. Please
>write a proper short description (ie: the first line after
>"Description:") and a long description (what goes after that first line)
>as *not* the continuation of the first line. It's very much ok to repeat
>the short description in the long one. This is also a blocker for me to
>sponsor the package.

Sorry about this, I guess I wanted to write a small description, forgot=20
about it, and just put the long description instead. It should be fixed=20
now.

>You're packaging the doc "as-is" without using Sphinx to build it. Any
>reason why, or you just don't know how yet? :) I'd suggest looking at
>other Python package building a -doc package to fix this. I'd also
>suggest packaging the doc in a separate -doc package.

Woops, I guess I didn't look closely to the build logs... And I did this=20
for a package used for generating doc: I should be punished for that :).

>Also, please remove:
>
>[import-orig]
>merge-mode =3D replace
>
>from debian/gbp.conf. This is typically something that goes into
>~/.gbp.conf rather than on individual packages.

I don't agree with you on this one. To me, this kind of setting should=20
be put in the package, to have an uniform way of updating/building/etc.=20
a given package, whoever the uploader could be.

>Can you explain in more details than in debian/rules why you're
>overriding override_dh_auto_clean ? What does it try to download, apart
>from the build dependencies? Can't you set $clean_source =3D 0; in your
>~/.sbuildrc instead?

Mmh, I don't remember about this... I probably copied it from another of=20
my packages, without looking at it. It works without, so I removed it.=20
I'll try to find what this other package is to see if I can fix it=20
properly :-).

Note that I found and patched another access to the internet during=20
build (see 0001-Use-local-object-inventory-files-for-sphinx.patch).

More generally, I disagree with needing special settings in ~/.sbuildrc=20
(or other user configuration, or special command line arguments) before=20
updating a package. I think that is just making life harder for=20
(potential) future uploaders.

>I hope this helps,

Sure, thanks! I have to say that I was starting filling quite=20
demotivated because of not finding a sponsor for this little package...=20
(And I have the same issue for other haskell packages, maybe I should=20
finally complete the procedure to apply for becoming a DD...). I hope I=20
fixed the issues you found and that you will agree with my argument for=20
the debian/gbp.conf setting.

The new package is at https://mentors.debian.net/debian/pool/main/s/sphinx-=
autoapi/sphinx-autoapi_1.3.0-1.dsc

Regards,

--=20
F=C3=A9lix

--mP3DRpeJDSE+ciuQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQR6zeIsS8L0XLQfqiQBpfxHUdFE8AUCXpxtIAAKCRABpfxHUdFE
8LtwAQDoAEeMGJXlhCf5im9XFeS1tiXPda+hQO8IcpKOdo0nswD9GX3MD/jKk7gL
CdIoNNj+Z15+7zGoUbo7a8KglwIIMA0=
=oapQ
-----END PGP SIGNATURE-----

--mP3DRpeJDSE+ciuQ--