Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684425

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

Show all headers | View raw

> 1) I think most of it should be some cfg80211 shareable code.

I’m not sure exactly what you mean by this, could you please clarify?

> 2) This "rxtx" while surely present in other places sounds like a
> workaround for LED subsystem limitation. Maybe it's time to finally
> rework LED triggers.

I agree that it’s not an ideal way to do things, but I couldn’t think of a
better alternative. I think that having a combined trigger is useful though, for
situations like using the single LED on a Raspberry Pi to show Wi-Fi activity.


> On 10 Jul 2017, at 10:48, Rafał Miłecki <zajec5@gmail.com> wrote:
> 
> On 7 July 2017 at 16:09, Russell Joyce <russell.joyce@york.ac.uk> wrote:
>> Add three basic LED triggers to brcmfmac, based on those in mac80211: one
>> for transmit, one for receive, and one for combined transmit/receive.
>> 
>> Signed-off-by: Russell Joyce <russell.joyce@york.ac.uk>
> 
> 1) I think most of it should be some cfg80211 shareable code.
> 2) This "rxtx" while surely present in other places sounds like a
> workaround for LED subsystem limitation. Maybe it's time to finally
> rework LED triggers.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce <russell.joyce@york.ac.uk> - 2017-07-07 16:20 +0200
  Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Rafał Miłecki <zajec5@gmail.com> - 2017-07-10 11:50 +0200
    Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce <russell.joyce@york.ac.uk> - 2017-07-10 19:10 +0200
      Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-07-11 11:00 +0200
        Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce <russell.joyce@york.ac.uk> - 2017-07-11 17:10 +0200
          Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Rafał Miłecki <zajec5@gmail.com> - 2017-07-17 07:00 +0200

csiph-web