Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

From	Russell Joyce <russell.joyce@york.ac.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] brcmfmac: added LED triggers for transmit/receive
Date	2017-07-11 17:10 +0200
Message-ID	<u24Xw-3TD-9@gated-at.bofh.it> (permalink)
References	<u0CgW-5bd-7@gated-at.bofh.it> <u1Dui-3kz-23@gated-at.bofh.it> <u1Km7-7MA-23@gated-at.bofh.it> <u1Zbs-8vM-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Thanks for your comments.

> What I think Rafał is saying is that it would be better to have this
> code in cfg80211 so other drivers including mac80211 could use it.


While I agree that moving all wireless LED triggers to cfg80211 would be an
ideal situation, it seems a bit out of scope for what I was trying to achieve.
This would probably also require removing the mac80211 LED triggers (and any
other similar triggers that might be created by specific wireless drivers not
using mac80211), in order to consolidate them in one place.

Besides this, I'm not sure where exactly in cfg80211 this functionality would
go (I assume it was originally put in mac80211 instead for a reason?),
although I'm certainly no expert in this area of the kernel.

> Indeed. However, the LED subsystem could/should(?) take care of mapping
> "rx" and "tx" triggers to the same LED.

In terms of the LED triggers, the only alternative I can see is to create a
single complex trigger that exposes "rx" and "tx" parameters that can be
individually enabled or disabled. This would reduce the number of triggers from
three to one, but also makes things slightly more awkward for the user, and
deviates from the convention set by mac80211.

Thread

[PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce <russell.joyce@york.ac.uk> - 2017-07-07 16:20 +0200
  Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Rafał Miłecki <zajec5@gmail.com> - 2017-07-10 11:50 +0200
    Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce <russell.joyce@york.ac.uk> - 2017-07-10 19:10 +0200
      Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-07-11 11:00 +0200
        Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce <russell.joyce@york.ac.uk> - 2017-07-11 17:10 +0200
          Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Rafał Miłecki <zajec5@gmail.com> - 2017-07-17 07:00 +0200

csiph-web