Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

From	Arend van Spriel <arend.vanspriel@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] brcmfmac: added LED triggers for transmit/receive
Date	2017-07-11 11:00 +0200
Message-ID	<u1Zbs-8vM-9@gated-at.bofh.it> (permalink)
References	<u0CgW-5bd-7@gated-at.bofh.it> <u1Dui-3kz-23@gated-at.bofh.it> <u1Km7-7MA-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10-07-17 19:02, Russell Joyce wrote:
>> 1) I think most of it should be some cfg80211 shareable code.
> 
> I’m not sure exactly what you mean by this, could you please clarify?

What I think Rafał is saying is that it would be better to have this
code in cfg80211 so other drivers including mac80211 could use it.

>> 2) This "rxtx" while surely present in other places sounds like a
>> workaround for LED subsystem limitation. Maybe it's time to finally
>> rework LED triggers.
> 
> I agree that it’s not an ideal way to do things, but I couldn’t think of a
> better alternative. I think that having a combined trigger is useful though, for
> situations like using the single LED on a Raspberry Pi to show Wi-Fi activity.

Indeed. However, the LED subsystem could/should(?) take care of mapping
"rx" and "tx" triggers to the same LED.

I am happy to comment on your patch, but maybe you can first take a look
at the suggestion Rafał made above.

Regards,
Arend

Thread

[PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce <russell.joyce@york.ac.uk> - 2017-07-07 16:20 +0200
  Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Rafał Miłecki <zajec5@gmail.com> - 2017-07-10 11:50 +0200
    Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce <russell.joyce@york.ac.uk> - 2017-07-10 19:10 +0200
      Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-07-11 11:00 +0200
        Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce <russell.joyce@york.ac.uk> - 2017-07-11 17:10 +0200
          Re: [PATCH] brcmfmac: added LED triggers for transmit/receive Rafał Miłecki <zajec5@gmail.com> - 2017-07-17 07:00 +0200

csiph-web