Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1684424

Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures.

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures.
Date 2017-07-10 19:10 +0200
Message-ID <u1Km7-7MA-25@gated-at.bofh.it> (permalink)
References <u1EgG-3Sw-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 2017-07-10 at 16:04 +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.

I think it's good you are doing all of these.

Instead of individually sending these patches, could you
please send a patch series for all of these attribute_group
patches with a cover letter at the same time?

That could make it easier for a trivial maintainer to apply
all of these at once and not get some applied and others
ignored or dropped on the floor.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: chelsio: cxgb3: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-10 12:40 +0200
  Re: [PATCH] net: chelsio: cxgb3: constify attribute_group  structures. Joe Perches <joe@perches.com> - 2017-07-10 19:10 +0200
    Re: [PATCH] net: chelsio: cxgb3: constify attribute_group  structures. Joe Perches <joe@perches.com> - 2017-07-11 07:50 +0200
      Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 08:00 +0200
    Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 07:50 +0200

csiph-web