Re: lockdep warning: console vs. mem hotplug

From	Sebastian Ott <sebott@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: lockdep warning: console vs. mem hotplug
Date	2017-03-25 12:00 +0100
Message-ID	<toRAm-85v-9@gated-at.bofh.it> (permalink)
References	<tn9i1-7Yx-9@gated-at.bofh.it> <tnjU6-6J9-25@gated-at.bofh.it> <toHrk-ZP-35@gated-at.bofh.it>
Organization	"IBM Deutschland Research & Development GmbH / Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294"

Show all headers | View raw

On Sat, 25 Mar 2017, Sergey Senozhatsky wrote:

> On (03/21/17 13:44), Sergey Senozhatsky wrote:
> [..]
> > so we probably can
> > 
> > 
> > 1) move pr_info() out of zone->lock in __offline_isolated_pages().
> >    meh...
> > 
> > 
> > 2) switch to printk_deferred() in __offline_isolated_pages().
> >    meh.. there might a bunch of other printks done from under zone->lock.
> > 
> > 
> > 3) move add_timer() out of sclp_con_lock console in sclp_console_write().
> >    well, there can be other consoles that do something similar.
> > 
> > 
> > 4) ... something smart.
> 
> 
> Sebastian, does this change make lockdep happy?
> 
> it removes console drivers from the __offline_isolated_pages(). not the
> best solution I can think of, but the simplest one.

It does. No complaint from lockdep.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-21 05:50 +0100
  Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-21 06:10 +0100
  Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-03-25 01:10 +0100
    Re: lockdep warning: console vs. mem hotplug Steven Rostedt <rostedt@goodmis.org> - 2017-03-25 02:10 +0100
      Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-03-25 02:40 +0100
    Re: lockdep warning: console vs. mem hotplug Sebastian Ott <sebott@linux.vnet.ibm.com> - 2017-03-25 12:00 +0100

csiph-web