Re: lockdep warning: console vs. mem hotplug

From	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Newsgroups	linux.kernel
Subject	Re: lockdep warning: console vs. mem hotplug
Date	2017-03-25 02:40 +0100
Message-ID	<toIQp-1P9-5@gated-at.bofh.it> (permalink)
References	<tn9i1-7Yx-9@gated-at.bofh.it> <tnjU6-6J9-25@gated-at.bofh.it> <toHrk-ZP-35@gated-at.bofh.it> <toInn-1Fh-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (03/24/17 21:08), Steven Rostedt wrote:
> > Sebastian, does this change make lockdep happy?
> > 
> > it removes console drivers from the __offline_isolated_pages(). not the
> > best solution I can think of, but the simplest one.
> > 
> > ---
> > 
> >  mm/page_alloc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index f749b7ff7c50..eb61e6ab5f4f 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -7705,7 +7705,7 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
> >  		BUG_ON(!PageBuddy(page));
> >  		order = page_order(page);
> >  #ifdef CONFIG_DEBUG_VM
> > -		pr_info("remove from free list %lx %d %lx\n",
> > +		printk_deferred(KERN_INFO "remove from free list %lx %d %lx\n",
> >  			pfn, 1 << order, end_pfn);
> >  #endif
> >  		list_del(&page->lru);
> 
> 
> My fear is that this will trigger for any printk in page_alloc.c under
> the zone lock.

absolutely true.

I Cc'd debugobjects, mm and sclp_console maintainers because the
real (smart) solution to the problem is somewhere there.



another problem (not reported) is that we have conflicting dependencies
	mod_timer -> sclp_console
	sclp_console -> mod_timer

which can result in a deadlock:
	mod_timer -> debugobjects -> printk -> sclp_console -> mod_timer


this one, I think, can be addressed by switching to a printk_safe in debugobjects.


// I'm traveling now. there will be delays in replies, sorry.

	-ss

Thread

Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-21 05:50 +0100
  Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-21 06:10 +0100
  Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-03-25 01:10 +0100
    Re: lockdep warning: console vs. mem hotplug Steven Rostedt <rostedt@goodmis.org> - 2017-03-25 02:10 +0100
      Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-03-25 02:40 +0100
    Re: lockdep warning: console vs. mem hotplug Sebastian Ott <sebott@linux.vnet.ibm.com> - 2017-03-25 12:00 +0100

csiph-web