Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609039

Re: lockdep warning: console vs. mem hotplug

Show all headers | View raw

On (03/21/17 13:44), Sergey Senozhatsky wrote:
[..]
> so we probably can
> 
> 
> 1) move pr_info() out of zone->lock in __offline_isolated_pages().
>    meh...
> 
> 
> 2) switch to printk_deferred() in __offline_isolated_pages().
>    meh.. there might a bunch of other printks done from under zone->lock.
> 
> 
> 3) move add_timer() out of sclp_con_lock console in sclp_console_write().
>    well, there can be other consoles that do something similar.
> 
> 
> 4) ... something smart.


Sebastian, does this change make lockdep happy?

it removes console drivers from the __offline_isolated_pages(). not the
best solution I can think of, but the simplest one.

---

 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index f749b7ff7c50..eb61e6ab5f4f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -7705,7 +7705,7 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
 		BUG_ON(!PageBuddy(page));
 		order = page_order(page);
 #ifdef CONFIG_DEBUG_VM
-		pr_info("remove from free list %lx %d %lx\n",
+		printk_deferred(KERN_INFO "remove from free list %lx %d %lx\n",
 			pfn, 1 << order, end_pfn);
 #endif
 		list_del(&page->lru);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-21 05:50 +0100
  Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-21 06:10 +0100
  Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-03-25 01:10 +0100
    Re: lockdep warning: console vs. mem hotplug Steven Rostedt <rostedt@goodmis.org> - 2017-03-25 02:10 +0100
      Re: lockdep warning: console vs. mem hotplug Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-03-25 02:40 +0100
    Re: lockdep warning: console vs. mem hotplug Sebastian Ott <sebott@linux.vnet.ibm.com> - 2017-03-25 12:00 +0100

csiph-web