Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662302
| From | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage |
| Date | 2017-06-09 13:10 +0200 |
| Message-ID | <tQpXI-LP-17@gated-at.bofh.it> (permalink) |
| References | <tQp1F-dV-23@gated-at.bofh.it> |
| Organization | Free Electrons |
Hello, On Fri, 9 Jun 2017 12:09:17 +0200, Gregory CLEMENT wrote: > In some place in the driver regmap_update_bits was misused. Indeed the > last argument is not the value of the bit (or group of bits) itself but > the mask value inside the register. > > So when setting the bit N, then the value must be BIT(N) and not 1. > > CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz> > CC: Ralph Sennhauser <ralph.sennhauser@gmail.com> > Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Thanks for fixing this so quickly! Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] gpio: mvebu: fix regmap_update_bits usage Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-09 12:10 +0200
Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-09 13:10 +0200
Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-06-09 14:30 +0200
Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-12 00:00 +0200
Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:20 +0200
csiph-web