Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662302
| Path | csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage |
| Date | Fri, 09 Jun 2017 13:10:02 +0200 |
| Message-ID | <tQpXI-LP-17@gated-at.bofh.it> (permalink) |
| References | <tQp1F-dV-23@gated-at.bofh.it> |
| Organization | Free Electrons |
| X-Mailer | Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=US-ASCII |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 24 |
| X-Original-Cc | Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, linux-arm-kernel@lists.infradead.org, Chris Packham <Chris.Packham@alliedtelesis.co.nz>, Ralph Sennhauser <ralph.sennhauser@gmail.com> |
| X-Original-Date | Fri, 9 Jun 2017 13:01:25 +0200 |
| X-Original-Message-ID | <20170609130125.43b8258f@free-electrons.com> |
| X-Original-References | <20170609100917.26660-1-gregory.clement@free-electrons.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1662302 |
Show key headers only | View raw
Hello, On Fri, 9 Jun 2017 12:09:17 +0200, Gregory CLEMENT wrote: > In some place in the driver regmap_update_bits was misused. Indeed the > last argument is not the value of the bit (or group of bits) itself but > the mask value inside the register. > > So when setting the bit N, then the value must be BIT(N) and not 1. > > CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz> > CC: Ralph Sennhauser <ralph.sennhauser@gmail.com> > Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Thanks for fixing this so quickly! Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] gpio: mvebu: fix regmap_update_bits usage Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-09 12:10 +0200
Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-09 13:10 +0200
Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-06-09 14:30 +0200
Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-12 00:00 +0200
Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:20 +0200
csiph-web