Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage
Date	2017-06-16 11:20 +0200
Message-ID	<tSVA5-6x9-5@gated-at.bofh.it> (permalink)
References	<tQp1F-dV-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 9, 2017 at 12:09 PM, Gregory CLEMENT
<gregory.clement@free-electrons.com> wrote:

> In some place in the driver regmap_update_bits was misused. Indeed the
> last argument is not the value of the bit (or group of bits) itself but
> the mask value inside the register.
>
> So when setting the bit N, then the value must be BIT(N) and not 1.
>
> CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
> CC: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> Hi,
>
> In this second version I fixed the improper changed pointed by Thomas.

This version applied with the tags.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] gpio: mvebu: fix regmap_update_bits usage Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-09 12:10 +0200
  Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-09 13:10 +0200
  Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-06-09 14:30 +0200
    Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-12 00:00 +0200
  Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:20 +0200

csiph-web