Path: csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod From: Thomas Petazzoni Newsgroups: linux.kernel Subject: Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Date: Fri, 09 Jun 2017 13:10:02 +0200 Message-ID: References: Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 24 X-Original-Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Chris Packham , Ralph Sennhauser X-Original-Date: Fri, 9 Jun 2017 13:01:25 +0200 X-Original-Message-ID: <20170609130125.43b8258f@free-electrons.com> X-Original-References: <20170609100917.26660-1-gregory.clement@free-electrons.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1662302 Hello, On Fri, 9 Jun 2017 12:09:17 +0200, Gregory CLEMENT wrote: > In some place in the driver regmap_update_bits was misused. Indeed the > last argument is not the value of the bit (or group of bits) itself but > the mask value inside the register. > > So when setting the bit N, then the value must be BIT(N) and not 1. > > CC: Chris Packham > CC: Ralph Sennhauser > Signed-off-by: Gregory CLEMENT Reviewed-by: Thomas Petazzoni Thanks for fixing this so quickly! Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com