Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1484841
| From | Matt Fleming <matt@codeblueprint.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic |
| Date | 2016-09-16 11:40 +0200 |
| Message-ID | <shXMJ-2PA-9@gated-at.bofh.it> (permalink) |
| References | <shUvv-O3-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 16 Sep, at 08:05:12AM, Mike Galbraith wrote:
> Hi Matt,
>
> My workstation started instant rebooting with tip. I bisected it to..
>
> efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()
>
> ..but seems it's really $subject, as box works fine with the below.
>
> ---
> drivers/firmware/efi/efi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -415,6 +415,7 @@ void __init efi_mem_reserve(phys_addr_t
> {
> if (!memblock_is_region_reserved(addr, size))
> memblock_reserve(addr, size);
> + else
>
> /*
> * Some architectures (x86) reserve all boot services ranges
>
>
> No idea what's going boom down in efi_arch_mem_reserve().
Urgh, that's bad. Which machine is this? Can you paste the dmesg after
booting with the efi=debug kernel parameter, either with your above
patch or with the commit reverted?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[tip regression] efi: Allow drivers to reserve boot services forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-16 08:10 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-16 11:40 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-16 16:40 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mark Rutland <mark.rutland@arm.com> - 2016-09-16 16:50 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-16 20:30 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mark Rutland <mark.rutland@arm.com> - 2016-09-19 11:00 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-16 18:40 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-17 22:00 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-18 08:10 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-19 13:20 +0200
csiph-web