Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1486274
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic |
| Date | 2016-09-19 11:00 +0200 |
| Message-ID | <sj2AF-3cw-19@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <shXMJ-2PA-9@gated-at.bofh.it> <shYfN-3fW-51@gated-at.bofh.it> <si2t3-5We-7@gated-at.bofh.it> <si2CK-608-13@gated-at.bofh.it> <si63E-8pm-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Sep 16, 2016 at 08:26:16PM +0200, Mike Galbraith wrote: > On Fri, 2016-09-16 at 15:45 +0100, Mark Rutland wrote: > > > > diff --git a/arch/x86/platform/efi/quirks.c > > > b/arch/x86/platform/efi/quirks.c > > > index f14b7a9da24b..e881b4b2ffd6 100644 > > > --- a/arch/x86/platform/efi/quirks.c > > > +++ b/arch/x86/platform/efi/quirks.c > > > @@ -201,8 +201,10 @@ void __init efi_arch_mem_reserve(phys_addr_t > > > addr, u64 size) > > > return; > > > } > > > > > > + size = round_up(size, EFI_PAGE_SIZE); > > > > i.e. have: > > > > size += addr % EFI_PAGE_SIZE; > > size = round_up(size, EFI_PAGE_SIZE); > > addr = round_down(base, EFI_PAGE_SIZE); > ^^^^ > > s/base/addr did work, was that what you meant to write, or am I lucky? That was what I meant to write, though the two statements aren't necessarily mutually exclusive. ;) I'll have to leave it to you and Matt to figure out what the real solution is -- I'm not familiar with this code and was just pattern-matching. Thanks, Mark.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[tip regression] efi: Allow drivers to reserve boot services forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-16 08:10 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-16 11:40 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-16 16:40 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mark Rutland <mark.rutland@arm.com> - 2016-09-16 16:50 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-16 20:30 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mark Rutland <mark.rutland@arm.com> - 2016-09-19 11:00 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-16 18:40 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-17 22:00 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-18 08:10 +0200
Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-19 13:20 +0200
csiph-web