Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484840

[PATCH v2] skd: fix assert typo

Show all headers | View raw

The assert was missing a `!` to become active, but since that would only turn
it into a complicated codepath for a pr_err(), let's simply replace it.

CC: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 drivers/block/skd_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 3822eae..c04e92a 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -1905,7 +1905,7 @@ static void skd_send_internal_skspcl(struct skd_device *skdev,
 		break;
 
 	default:
-		SKD_ASSERT("Don't know what to send");
+		pr_err("Don't know what to send");
 		return;
 
 	}
@@ -2105,7 +2105,7 @@ static void skd_complete_internal(struct skd_device *skdev,
 		break;
 
 	default:
-		SKD_ASSERT("we didn't send this");
+		pr_err("we didn't send this");
 	}
 }
 
-- 
Cheers,
  Eric

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] skd: fix assert typo Jeff Moyer <jmoyer@redhat.com> - 2016-09-12 19:50 +0200
  [PATCH v2] skd: fix assert typo Eric Engestrom <eric.engestrom@imgtec.com> - 2016-09-16 11:40 +0200
    Re: [PATCH v2] skd: fix assert typo Johannes Thumshirn <jthumshirn@suse.de> - 2016-09-16 14:10 +0200
    Re: [PATCH v2] skd: fix assert typo Jeff Moyer <jmoyer@redhat.com> - 2016-09-16 14:50 +0200
      Re: [PATCH v2] skd: fix assert typo Eric Engestrom <eric.engestrom@imgtec.com> - 2016-09-16 15:10 +0200

csiph-web