[tip regression] efi: Allow drivers to reserve boot services forever == toxic

From	Mike Galbraith <umgwanakikbuti@gmail.com>
Newsgroups	linux.kernel
Subject	[tip regression] efi: Allow drivers to reserve boot services forever == toxic
Date	2016-09-16 08:10 +0200
Message-ID	<shUvv-O3-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Matt,

My workstation started instant rebooting with tip.  I bisected it to..

   efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()

..but seems it's really $subject, as box works fine with the below.

---
 drivers/firmware/efi/efi.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -415,6 +415,7 @@ void __init efi_mem_reserve(phys_addr_t
 {
 	if (!memblock_is_region_reserved(addr, size))
 		memblock_reserve(addr, size);
+	else
 
 	/*
 	 * Some architectures (x86) reserve all boot services ranges


No idea what's going boom down in efi_arch_mem_reserve().

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[tip regression]  efi: Allow drivers to reserve boot services  forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-16 08:10 +0200
  Re: [tip regression]  efi: Allow drivers to reserve boot services  forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-16 11:40 +0200
    Re: [tip regression]  efi: Allow drivers to reserve boot services  forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-16 16:40 +0200
      Re: [tip regression]  efi: Allow drivers to reserve boot services  forever == toxic Mark Rutland <mark.rutland@arm.com> - 2016-09-16 16:50 +0200
        Re: [tip regression]  efi: Allow drivers to reserve boot services  forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-16 20:30 +0200
          Re: [tip regression]  efi: Allow drivers to reserve boot services  forever == toxic Mark Rutland <mark.rutland@arm.com> - 2016-09-19 11:00 +0200
      Re: [tip regression]  efi: Allow drivers to reserve boot services  forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-16 18:40 +0200
        Re: [tip regression]  efi: Allow drivers to reserve boot services  forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-17 22:00 +0200
          Re: [tip regression]  efi: Allow drivers to reserve boot services  forever == toxic Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-09-18 08:10 +0200
            Re: [tip regression]  efi: Allow drivers to reserve boot services  forever == toxic Matt Fleming <matt@codeblueprint.co.uk> - 2016-09-19 13:20 +0200

csiph-web