Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401008

Re: [PATCH v2 2/4] phy: rockchip-emmc: configure frequency range and drive impedance

Show all headers | View raw

Hi,

On Fri, May 13, 2016 at 2:09 PM, Brian Norris <briannorris@chromium.org> wrote:
> From: Shawn Lin <shawn.lin@rock-chips.com>
>
> Signal integrity analysis has suggested we set these values. Do this in
> power_on(), so that they get reconfigured after suspend/resume.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> v2:
>  * Sent only patch 2/4 with version 2, to avoid spamming; will move on to v3
>    for all patches if I need to send another
>  * Drop 170 MHz comment; this was only applicable to a subtly different Arasan
>    PHY
>
>  drivers/phy/phy-rockchip-emmc.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)

As per my comments on v1, this is a sane starting point and seems like
a good idea to land.  Hopefully someone at Rockchip can pick things up
and continue making this more configurable.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready Brian Norris <briannorris@chromium.org> - 2016-05-13 00:50 +0200
  [PATCH 3/4] phy: rockchip-emmc: configure default output tap delay Brian Norris <briannorris@chromium.org> - 2016-05-13 00:50 +0200
    Re: [PATCH 3/4] phy: rockchip-emmc: configure default output tap delay Doug Anderson <dianders@chromium.org> - 2016-05-14 00:30 +0200
      Re: [PATCH 3/4] phy: rockchip-emmc: configure default output tap  delay Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-16 06:20 +0200
        Re: [PATCH 3/4] phy: rockchip-emmc: configure default output tap delay Doug Anderson <dianders@chromium.org> - 2016-05-16 17:20 +0200
  [PATCH 2/4] phy: rockchip-emmc: configure frequency range and drive impedance Brian Norris <briannorris@chromium.org> - 2016-05-13 00:50 +0200
    Re: [PATCH 2/4] phy: rockchip-emmc: configure frequency range and  drive impedance Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-13 03:10 +0200
      Re: [PATCH 2/4] phy: rockchip-emmc: configure frequency range and  drive impedance Doug Anderson <dianders@chromium.org> - 2016-05-13 20:50 +0200
        Re: [PATCH 2/4] phy: rockchip-emmc: configure frequency range and  drive impedance Brian Norris <briannorris@chromium.org> - 2016-05-13 23:10 +0200
        Re: [PATCH 2/4] phy: rockchip-emmc: configure frequency range and  drive impedance Doug Anderson <dianders@chromium.org> - 2016-05-24 07:00 +0200
    [PATCH v2 2/4] phy: rockchip-emmc: configure frequency range and  drive impedance Brian Norris <briannorris@chromium.org> - 2016-05-13 23:10 +0200
      Re: [PATCH v2 2/4] phy: rockchip-emmc: configure frequency range and  drive impedance Doug Anderson <dianders@chromium.org> - 2016-05-14 00:10 +0200
  [PATCH 4/4] phy: rockchip-emmc: reindent the register definitions Brian Norris <briannorris@chromium.org> - 2016-05-13 00:50 +0200
    Re: [PATCH 4/4] phy: rockchip-emmc: reindent the register definitions Doug Anderson <dianders@chromium.org> - 2016-05-14 00:30 +0200
  Re: [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready Doug Anderson <dianders@chromium.org> - 2016-05-14 00:10 +0200

csiph-web