Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1363323
| From | Sebastian Frias <sf84@laposte.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY |
| Date | 2016-03-23 11:50 +0100 |
| Message-ID | <rfOwp-25L-1@gated-at.bofh.it> (permalink) |
| References | (6 earlier) <rfa5Y-7FH-27@gated-at.bofh.it> <rfesW-2eY-13@gated-at.bofh.it> <rfvDs-5NV-25@gated-at.bofh.it> <rfAts-Np-5@gated-at.bofh.it> <rfO3p-1S7-49@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
This removes the dependency on GPIOLIB for non faulty PHYs.
Indeed, without this patch, if GPIOLIB is not selected
devm_gpiod_get_optional() will return -ENOSYS and the driver probe
call will fail, regardless of the actual PHY hardware.
Out of the 3 PHYs supported by this driver (AT8030, AT8031, AT8035),
only AT8030 presents the issues that commit 13a56b449325 ("net: phy:
at803x: Add support for hardware reset") attempts to work-around by
using a 'reset' GPIO line.
Hence, only AT8030 should depend on GPIOLIB operating properly.
Fixes: 13a56b449325 ("net: phy: at803x: Add support for hardware reset")
Signed-off-by: Sebastian Frias <sf84@laposte.net>
---
drivers/net/phy/at803x.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 2174ec9..dcecf25 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -251,12 +251,16 @@ static int at803x_probe(struct phy_device *phydev)
if (!priv)
return -ENOMEM;
+ if (phydev->drv->phy_id != ATH8030_PHY_ID)
+ goto does_not_require_reset_workaround;
+
gpiod_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
if (IS_ERR(gpiod_reset))
return PTR_ERR(gpiod_reset);
priv->gpiod_reset = gpiod_reset;
+does_not_require_reset_workaround:
phydev->priv = priv;
return 0;
--
2.1.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-03-18 14:00 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-18 17:20 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-03-18 20:20 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-18 20:40 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-03-18 21:20 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-18 21:50 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Måns Rullgård <mans@mansr.com> - 2016-03-19 11:10 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-21 13:50 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-03-21 15:20 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-21 16:40 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-03-21 21:20 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-22 15:40 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-03-22 20:50 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-23 11:20 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-23 11:40 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-23 12:00 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-23 11:20 +0100
[PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sebastian Frias <sf84@laposte.net> - 2016-03-23 11:50 +0100
Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY David Miller <davem@davemloft.net> - 2016-03-23 18:50 +0100
Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-23 20:50 +0100
Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sebastian Frias <sf84@laposte.net> - 2016-03-24 11:00 +0100
Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sebastian Frias <sf84@laposte.net> - 2016-03-24 11:20 +0100
Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-24 14:50 +0100
Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-22 15:40 +0100
csiph-web