Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

From	Måns Rullgård <mans@mansr.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB
Date	2016-03-19 11:10 +0100
Message-ID	<relZv-6PZ-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <re5i3-1rG-21@gated-at.bofh.it> <re86e-5Tk-3@gated-at.bofh.it> <re8pz-6iL-1@gated-at.bofh.it> <re92i-7qP-13@gated-at.bofh.it> <re9vk-824-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Mason <slash.tmp@free.fr> writes:

> On 18/03/2016 21:11, Uwe Kleine-König wrote:
>
>> Hello,
>> 
>> On Fri, Mar 18, 2016 at 08:31:20PM +0100, Mason wrote:
>>
>>> On 18/03/2016 20:12, Uwe Kleine-König wrote:
>>>
>>>> On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote:
>>>>
>>>>> What would you think of making at803x_link_change_notify() print a
>>>>> message every time it should do a reset but does not has a way to do it?
>>>>
>>>> Then this question is obsolete because the device doesn't probe.
>>>
>>> I don't understand this statement.
>>>
>>> What does it mean for a question to be obsolete?
>> 
>> If the driver doesn't probe because it cannot control the reset line,
>> you don't need to think about how it should behave in
>> at803x_link_change_notify without control of the reset line, because
>> this code isn't reached then.
>
> If I understand correctly, it is possible to soft-reset the PHY
> by writing to a specific register. The GPIO pin is useful only to
> force a hardware-reset when the PHY is wedged by some random event.

Yes, and some variants of this phy are broken and require a hard reset
in certain situations.  At least that's what the comment in the code
says.

-- 
Måns Rullgård

Thread

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-18 14:00 +0100
  Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-18 17:20 +0100
    Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-18 20:20 +0100
      Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-18 20:40 +0100
        Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-18 21:20 +0100
          Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-18 21:50 +0100
            Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Måns Rullgård <mans@mansr.com> - 2016-03-19 11:10 +0100
      Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-21 13:50 +0100
        Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-21 15:20 +0100
          Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-21 16:40 +0100
            Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-21 21:20 +0100
              Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-22 15:40 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-22 20:50 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-23 11:20 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-23 11:40 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-23 12:00 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-23 11:20 +0100
                [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sebastian Frias <sf84@laposte.net> - 2016-03-23 11:50 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY David Miller <davem@davemloft.net> - 2016-03-23 18:50 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-23 20:50 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sebastian Frias <sf84@laposte.net> - 2016-03-24 11:00 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sebastian Frias <sf84@laposte.net> - 2016-03-24 11:20 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-24 14:50 +0100
    Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-22 15:40 +0100

csiph-web