Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363329

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

From Sebastian Frias <sf84@laposte.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB
Date 2016-03-23 12:00 +0100
Message-ID <rfOG6-298-11@gated-at.bofh.it> (permalink)
References (7 earlier) <rfesW-2eY-13@gated-at.bofh.it> <rfvDs-5NV-25@gated-at.bofh.it> <rfAts-Np-5@gated-at.bofh.it> <rfO3n-1S7-13@gated-at.bofh.it> <rfOmK-22n-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Sergei,

On 03/23/2016 11:39 AM, Sergei Shtylyov wrote:
>>          gpiod_reset = devm_gpiod_get_optional(dev, "reset",
>> GPIOD_OUT_HIGH);
> 
>    We shouldn't call _optional() then, should we?

I could imagine the original intention was to be backward compatible.

Indeed, if this call is not optional, systems using AT8030 and lacking a
reset line on DT will have their behaviour affected.
NOTE: they would still work because even if this driver fails to bind a
generic one will take over.

Best regards,

Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-18 14:00 +0100
  Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-18 17:20 +0100
    Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-18 20:20 +0100
      Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-18 20:40 +0100
        Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-18 21:20 +0100
          Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-18 21:50 +0100
            Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Måns Rullgård <mans@mansr.com> - 2016-03-19 11:10 +0100
      Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-21 13:50 +0100
        Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-21 15:20 +0100
          Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-21 16:40 +0100
            Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-21 21:20 +0100
              Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-22 15:40 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-22 20:50 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-23 11:20 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-23 11:40 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-23 12:00 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-23 11:20 +0100
                [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sebastian Frias <sf84@laposte.net> - 2016-03-23 11:50 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY David Miller <davem@davemloft.net> - 2016-03-23 18:50 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-23 20:50 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sebastian Frias <sf84@laposte.net> - 2016-03-24 11:00 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sebastian Frias <sf84@laposte.net> - 2016-03-24 11:20 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-24 14:50 +0100
    Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-22 15:40 +0100

csiph-web