Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364036

Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

From Sebastian Frias <sf84@laposte.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY
Date 2016-03-24 11:00 +0100
Message-ID <rgadB-EQ-13@gated-at.bofh.it> (permalink)
References (8 earlier) <rfvDs-5NV-25@gated-at.bofh.it> <rfAts-Np-5@gated-at.bofh.it> <rfO3p-1S7-49@gated-at.bofh.it> <rfOwp-25L-1@gated-at.bofh.it> <rfWWZ-8bL-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Sergei,

On 03/23/2016 08:42 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 03/23/2016 01:49 PM, Sebastian Frias wrote:
> 
>> This removes the dependency on GPIOLIB for non faulty PHYs.
>>
>> Indeed, without this patch, if GPIOLIB is not selected
>> devm_gpiod_get_optional() will return -ENOSYS and the driver probe
>> call will fail, regardless of the actual PHY hardware.
>>
>> Out of the 3 PHYs supported by this driver (AT8030, AT8031, AT8035),
>> only AT8030 presents the issues that commit 13a56b449325 ("net: phy:
>> at803x: Add support for hardware reset") attempts to work-around by
>> using a 'reset' GPIO line.
>>
>> Hence, only AT8030 should depend on GPIOLIB operating properly.
>>
>> Fixes: 13a56b449325 ("net: phy: at803x: Add support for hardware reset")
>>
>> Signed-off-by: Sebastian Frias <sf84@laposte.net>
> [...]
> 
>    What I don't understand is why the link_change_notify() method ptr is
> populated for all 3 supported chips while only being needed on 8030...

You are right.
I had commented on that here
https://marc.info/?l=linux-netdev&m=145856582932498&w=2

<quote>
Furthermore, I think we should not even register the
"link_change_notify" callback when dealing with AT803x PHYs that do not
require the hack.
Another solution (considering the callback is statically registered in
the "phy_driver" structs for all AT803x PHYs) would be for the callback
to disable itself.
</quote>

I was waiting for comments from the original implementor.

However, I guess we can remove them as well.
I will make another patch.

Best regards,

Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-18 14:00 +0100
  Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-18 17:20 +0100
    Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-18 20:20 +0100
      Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-18 20:40 +0100
        Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-18 21:20 +0100
          Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-18 21:50 +0100
            Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Måns Rullgård <mans@mansr.com> - 2016-03-19 11:10 +0100
      Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-21 13:50 +0100
        Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-21 15:20 +0100
          Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-21 16:40 +0100
            Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-21 21:20 +0100
              Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-22 15:40 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-22 20:50 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason <slash.tmp@free.fr> - 2016-03-23 11:20 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-23 11:40 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-23 12:00 +0100
                Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-23 11:20 +0100
                [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sebastian Frias <sf84@laposte.net> - 2016-03-23 11:50 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY David Miller <davem@davemloft.net> - 2016-03-23 18:50 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-23 20:50 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sebastian Frias <sf84@laposte.net> - 2016-03-24 11:00 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sebastian Frias <sf84@laposte.net> - 2016-03-24 11:20 +0100
                Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030  PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-24 14:50 +0100
    Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias <sf84@laposte.net> - 2016-03-22 15:40 +0100

csiph-web