Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446056

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

From Oliver Neukum <oneukum@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling
Date 2016-07-19 08:30 +0200
Message-ID <rWwHv-tr-1@gated-at.bofh.it> (permalink)
References (2 earlier) <rWgMq-6KQ-15@gated-at.bofh.it> <rWhfr-6UE-1@gated-at.bofh.it> <rWhyN-7ha-21@gated-at.bofh.it> <rWhyN-7ha-19@gated-at.bofh.it> <rWilb-7Qr-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-07-18 at 17:04 +0200, Kristian Evensen wrote:
> On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum <oneukum@suse.com> wrote:
> >> Ok, sounds good. So far, I have only seen the random MAC issue with
> >> the three previously mentioned devices, but who knows how many else is
> >> out there with the same error ... I don't think it should be in the
> >> core ethernet code, at least not yet, but I agree it would make sense
> >> to move it to for example usbnet_core(). If you agree, I can prepare a
> >> patch for it.
> >
> > I don't see how it would be specific for a subsystem. If the patch
> > is correct, it belongs into the networking core.
> 
> I had a look at some other drivers, and I think we need to be very
> careful about making setting a random MAC too generic. For example, we
> might be unlucky and break the possibly_iphdr()-code/assumption in
> qmi_wwan.c. And there is probably more code/assumptions like that in
> the network stack.

In this case please use special cases for usbnet, too.
We need a quirk.

	Regards
		Oliver

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 14:30 +0200
  Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-18 15:10 +0200
    Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 15:30 +0200
      Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-18 16:00 +0200
        Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-18 16:20 +0200
          Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 16:30 +0200
          Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 17:10 +0200
            Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-19 08:30 +0200
              Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-19 08:50 +0200
                Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-19 10:00 +0200
                Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Lars Melin <larsm17@gmail.com> - 2016-07-19 10:40 +0200
                Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-19 13:10 +0200
        Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 16:20 +0200

csiph-web