Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446065

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

From Kristian Evensen <kristian.evensen@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling
Date 2016-07-19 08:50 +0200
Message-ID <rWx0R-BC-15@gated-at.bofh.it> (permalink)
References (3 earlier) <rWhfr-6UE-1@gated-at.bofh.it> <rWhyN-7ha-21@gated-at.bofh.it> <rWhyN-7ha-19@gated-at.bofh.it> <rWilb-7Qr-11@gated-at.bofh.it> <rWwHv-tr-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 19, 2016 at 8:20 AM, Oliver Neukum <oneukum@suse.com> wrote:
>> I had a look at some other drivers, and I think we need to be very
>> careful about making setting a random MAC too generic. For example, we
>> might be unlucky and break the possibly_iphdr()-code/assumption in
>> qmi_wwan.c. And there is probably more code/assumptions like that in
>> the network stack.
>
> In this case please use special cases for usbnet, too.
> We need a quirk.

I guess I can match on the VID/PID in usbnet, but won't it be cleaner
to add a new bind() function (in cdc_ether) which matches the two PIDs
and leave usbnet as is? Or am I misunderstanding how to add this
functionality to usbnet?

-Kristian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 14:30 +0200
  Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-18 15:10 +0200
    Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 15:30 +0200
      Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-18 16:00 +0200
        Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-18 16:20 +0200
          Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 16:30 +0200
          Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 17:10 +0200
            Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-19 08:30 +0200
              Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-19 08:50 +0200
                Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-19 10:00 +0200
                Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Lars Melin <larsm17@gmail.com> - 2016-07-19 10:40 +0200
                Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-19 13:10 +0200
        Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 16:20 +0200

csiph-web