Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use device dependencies)

From	Marek Szyprowski <m.szyprowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use device dependencies)
Date	2016-07-19 08:30 +0200
Message-ID	<rWwHv-tr-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <rVblM-7q0-5@gated-at.bofh.it> <rWe7T-4ZV-1@gated-at.bofh.it> <rWeAV-5p6-9@gated-at.bofh.it> <rWhfr-6UE-7@gated-at.bofh.it> <rWjTY-fe-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Tobias


On 2016-07-18 18:43, Tobias Jakobi wrote:
> Marek Szyprowski wrote:
>> On 2016-07-18 13:00, Tobias Jakobi wrote:
>>> Marek Szyprowski wrote:
>>>> On 2016-07-15 15:21, Tobias Jakobi wrote:
>>>>> Tobias Jakobi wrote:
>>>>>> Hello Marek,
>>>>>>
>>>>>> I've tested the patchset on 4.7-rc7 and noticed that it breaks
>>>>>> reboot on
>>>>>> my ODROID-X2.
>>>>>>
>>>>>> Going to check where exactly things break.
>>>>> Sadly it's the last patch where everything comes together:
>>>>> "iommu/exynos: Add proper runtime pm support"
>>>>>
>>>>> I still have to check if forcing runpm status to 'on' makes a
>>>>> difference. I suspect that the aggressive clock gating might be the
>>>>> reason?
>>>> Thanks for testing. I will check this issue. Could you send me your
>>>> .config?
>>> This is the config I'm currently using:
>>> https://github.com/tobiasjakobi/odroid-environment/blob/master/sourcecode/system/vanilla-4.7-debug.conf
>>>
>>>
>>> Do you think checking this with no_console_suspend makes sense?
>> no_console_suspend switch won't provide more information, but I managed
>> to reproduce your issue. I'm really confused how enabling runtime pm can
>> cause problems with usb/smsc95xx ethernet driver (that is the reason for
>> failed reboot). Maybe it is somehow related to the global relations
>> between devices and drivers and the fact that creating the runtime pm
>> links change the order of operations. I will check this again when
>> Rafael send updated patches. Here is the log I got (after waiting some
>> time):
> thanks for looking into this! I'll try to reproduce this on my board. I
> have to admit that I didn't wait too long for the hung task message to
> appear.
>
> I wonder if this has something to do with regulator code cutting some
> supplies too early. Is this on a X2 or a U2/U3?

I've reproduced it on U3.

> I'm not sure if we
> currently model the regulator setup correctly here (IIRC then buck8 is
> supplying the LAN/USB block on U2/U3).

IMHO it is not really related to regulator operations, but the sequence
of shutting down logical devices in the system. For some reasons when pm 
links
are used, something changes the order of operations in system shutdown
procedure, what causes smsc95xx to hang. I have no idea why, but I don't 
have
time to investigate it further. I will wait for the next release of Rafael's
pm links patches and then check everything again.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

Thread

Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use  device dependencies) Tobias Jakobi <tjakobi@math.uni-bielefeld.de> - 2016-07-14 17:50 +0200
  Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use  device dependencies) Tobias Jakobi <tjakobi@math.uni-bielefeld.de> - 2016-07-15 15:30 +0200
    Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use  device dependencies) Marek Szyprowski <m.szyprowski@samsung.com> - 2016-07-18 12:40 +0200
      Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use  device dependencies) Tobias Jakobi <tjakobi@math.uni-bielefeld.de> - 2016-07-18 13:10 +0200
        Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use  device dependencies) Marek Szyprowski <m.szyprowski@samsung.com> - 2016-07-18 16:00 +0200
          Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use  device dependencies) Tobias Jakobi <tjakobi@math.uni-bielefeld.de> - 2016-07-18 18:50 +0200
            Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use  device dependencies) Marek Szyprowski <m.szyprowski@samsung.com> - 2016-07-19 08:30 +0200
              Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use  device dependencies) Tobias Jakobi <tjakobi@math.uni-bielefeld.de> - 2016-07-24 20:10 +0200

csiph-web