Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

From	Kristian Evensen <kristian.evensen@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling
Date	2016-07-18 16:20 +0200
Message-ID	<rWhyN-7ha-21@gated-at.bofh.it> (permalink)
References	<rWfQm-65G-29@gated-at.bofh.it> <rWgt4-6Eh-33@gated-at.bofh.it> <rWgMq-6KQ-15@gated-at.bofh.it> <rWhfr-6UE-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 18, 2016 at 3:50 PM, Oliver Neukum <oneukum@suse.com> wrote:
> No, you misunderstand me. I don't want quirks if we can avoid it.
> But if you need to do this for rndis_host and cdc_ether and maybe other
> drivers you should not be touching drivers. This belongs into the core
> ethernet code. Your code is good, but you are putting it in the wrong
> places.

Ok, sounds good. So far, I have only seen the random MAC issue with
the three previously mentioned devices, but who knows how many else is
out there with the same error ... I don't think it should be in the
core ethernet code, at least not yet, but I agree it would make sense
to move it to for example usbnet_core(). If you agree, I can prepare a
patch for it.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 14:30 +0200
  Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-18 15:10 +0200
    Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 15:30 +0200
      Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-18 16:00 +0200
        Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-18 16:20 +0200
          Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 16:30 +0200
          Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 17:10 +0200
            Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-19 08:30 +0200
              Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-19 08:50 +0200
                Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Oliver Neukum <oneukum@suse.com> - 2016-07-19 10:00 +0200
                Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Lars Melin <larsm17@gmail.com> - 2016-07-19 10:40 +0200
                Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-19 13:10 +0200
        Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen <kristian.evensen@gmail.com> - 2016-07-18 16:20 +0200

csiph-web