Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup

From	Craig Inches <xayto@xayto.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup
Date	2016-06-19 22:00 +0200
Message-ID	<rLR2V-6LE-7@gated-at.bofh.it> (permalink)
References	<rLvYt-14U-3@gated-at.bofh.it> <rLvYt-14U-7@gated-at.bofh.it> <rLAlr-3Xa-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

I did build the kernel 1 for each change, then a final with all changes
applied.

Apologies if I missed something,

Craig

On Sat, Jun 18, 2016 at 07:02:35PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote:
> > Macros with complex values should be enclosed in parenthesis
> > 
> > Signed-off-by: Craig Inches <craig@craiginches.com>
> > ---
> >  drivers/staging/lustre/lustre/include/cl_object.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> ALWAYS test build your patches, to not do so just makes maintainers
> grumpy...
> 
> Remember, checkpatch is a _hint_, it's not always right.
> 
> greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] staging: luster: Checkpatch Cleanup Craig Inches <craig@craiginches.com> - 2016-06-18 23:30 +0200
  Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-19 04:10 +0200
    Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup Craig Inches <xayto@xayto.net> - 2016-06-19 22:00 +0200

csiph-web