Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Craig Inches <xayto@xayto.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup
Date	Sun, 19 Jun 2016 22:00:01 +0200
Message-ID	<rLR2V-6LE-7@gated-at.bofh.it> (permalink)
References	<rLvYt-14U-3@gated-at.bofh.it> <rLvYt-14U-7@gated-at.bofh.it> <rLAlr-3Xa-3@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=xayto-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RzP7/37pJd6kIuPwptG1/ErlYDHAOmVqtBt/J9ZfX3g=; b=fw/5YAywbvUH7Wqf4k7IQMXLP1jRjvAvqK+kCc8YGsiIojVnuvMVyHcyOTjQV164FI d5DZrGS27QuzOIwS6rSx17Ru9oUU6ItWiawe2zJjACtCUnJJpmjndwQ880O5pQpI0dK0 OHMh2Aw44rBz1dKWVAXrJqJX6JzAGRpnVQdV9LpCDn7gXki6u3ynT2BK5Wt6YZ7LprOm RjtitZXeH+mjTs1T3pYjOZ4n9R80Q2b2Vnrx2xdnODYMtHkSYuYeP6hoYVAVQqfbxNMF 4uQb65uDIyKNSUqqABd0a/RXYmVngAMZzugdJSX4aonzUWjSQrMEg7B/92KIy6cIP9sE hc0A==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RzP7/37pJd6kIuPwptG1/ErlYDHAOmVqtBt/J9ZfX3g=; b=jnKazAx4aE8vsWM6EQwV7tPlxHUGCeDmijUq8M7oc61iwYlEkL7bemME7sM7eni/1b cQndPeUq27aVVaKbUw10bKKWoyG0QNNrCv95HfBwvZ30VRPWJM18zElV5upiN3tUqN2G zW2W/HDVV/D2M5gf2mJhShJMoiKqskkws+NOQ02kKmK+jygMnSfAU77F8XMLppYvDdi2 ph/0+vdIgxSe7dXeMJXR5Cr2Ww/pVLHdLIIHnSN+jBwVYzTAgQ0bcFC6U8hKTT6ijMLu P0g87XcesgLn2bHhvuJbNcDZjmb8G3asT+36ZtaDZoIVSn0747KYKLNZ1Axgo3iQngkk fymw==
X-Gm-Message-State	ALyK8tLR+Pd+M0bosTl7TXSvkzH7icV6xbXlusKMTtJYGpaEP2tWwcOULbdlLF+CelDnIA==
X-Received	by 10.194.19.201 with SMTP id h9mr10833650wje.147.1466365992725; Sun, 19 Jun 2016 12:53:12 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	Oleg Drokin <oleg.drokin@intel.com>, Andreas Dilger <andreas.dilger@intel.com>, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Sun, 19 Jun 2016 20:53:12 +0100
X-Original-Message-ID	<20160619195312.GA6855@voyager>
X-Original-References	<cover.1466279901.git.craig@craiginches.com> <109b0da96b67ae70145433b585ada631a5f7c668.1466279901.git.craig@craiginches.com> <20160619020235.GA18034@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1426029

Show key headers only | View raw

I did build the kernel 1 for each change, then a final with all changes
applied.

Apologies if I missed something,

Craig

On Sat, Jun 18, 2016 at 07:02:35PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote:
> > Macros with complex values should be enclosed in parenthesis
> > 
> > Signed-off-by: Craig Inches <craig@craiginches.com>
> > ---
> >  drivers/staging/lustre/lustre/include/cl_object.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> ALWAYS test build your patches, to not do so just makes maintainers
> grumpy...
> 
> Remember, checkpatch is a _hint_, it's not always right.
> 
> greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] staging: luster: Checkpatch Cleanup Craig Inches <craig@craiginches.com> - 2016-06-18 23:30 +0200
  Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-19 04:10 +0200
    Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup Craig Inches <xayto@xayto.net> - 2016-06-19 22:00 +0200

csiph-web