Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1425856 > unrolled thread
| Started by | Craig Inches <craig@craiginches.com> |
|---|---|
| First post | 2016-06-18 23:30 +0200 |
| Last post | 2016-06-19 22:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/3] staging: luster: Checkpatch Cleanup Craig Inches <craig@craiginches.com> - 2016-06-18 23:30 +0200
Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-19 04:10 +0200
Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup Craig Inches <xayto@xayto.net> - 2016-06-19 22:00 +0200
| From | Craig Inches <craig@craiginches.com> |
|---|---|
| Date | 2016-06-18 23:30 +0200 |
| Subject | [PATCH 2/3] staging: luster: Checkpatch Cleanup |
| Message-ID | <rLvYt-14U-7@gated-at.bofh.it> |
Macros with complex values should be enclosed in parenthesis
Signed-off-by: Craig Inches <craig@craiginches.com>
---
drivers/staging/lustre/lustre/include/cl_object.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/cl_object.h b/drivers/staging/lustre/lustre/include/cl_object.h
index 3004625..712355a 100644
--- a/drivers/staging/lustre/lustre/include/cl_object.h
+++ b/drivers/staging/lustre/lustre/include/cl_object.h
@@ -1207,8 +1207,8 @@ struct cl_lock_descr {
#define DDESCR "%s(%d):[%lu, %lu]:%x"
#define PDESCR(descr) \
- cl_lock_mode_name((descr)->cld_mode), (descr)->cld_mode, \
- (descr)->cld_start, (descr)->cld_end, (descr)->cld_enq_flags
+ (cl_lock_mode_name((descr)->cld_mode), (descr)->cld_mode, \
+ (descr)->cld_start, (descr)->cld_end, (descr)->cld_enq_flags)
const char *cl_lock_mode_name(const enum cl_lock_mode mode);
--
2.7.3
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-06-19 04:10 +0200 |
| Message-ID | <rLAlr-3Xa-3@gated-at.bofh.it> |
| In reply to | #1425856 |
On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote: > Macros with complex values should be enclosed in parenthesis > > Signed-off-by: Craig Inches <craig@craiginches.com> > --- > drivers/staging/lustre/lustre/include/cl_object.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) ALWAYS test build your patches, to not do so just makes maintainers grumpy... Remember, checkpatch is a _hint_, it's not always right. greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Craig Inches <xayto@xayto.net> |
|---|---|
| Date | 2016-06-19 22:00 +0200 |
| Message-ID | <rLR2V-6LE-7@gated-at.bofh.it> |
| In reply to | #1425910 |
I did build the kernel 1 for each change, then a final with all changes applied. Apologies if I missed something, Craig On Sat, Jun 18, 2016 at 07:02:35PM -0700, Greg Kroah-Hartman wrote: > On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote: > > Macros with complex values should be enclosed in parenthesis > > > > Signed-off-by: Craig Inches <craig@craiginches.com> > > --- > > drivers/staging/lustre/lustre/include/cl_object.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > ALWAYS test build your patches, to not do so just makes maintainers > grumpy... > > Remember, checkpatch is a _hint_, it's not always right. > > greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web