Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1425910

Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup
Date 2016-06-19 04:10 +0200
Message-ID <rLAlr-3Xa-3@gated-at.bofh.it> (permalink)
References <rLvYt-14U-3@gated-at.bofh.it> <rLvYt-14U-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote:
> Macros with complex values should be enclosed in parenthesis
> 
> Signed-off-by: Craig Inches <craig@craiginches.com>
> ---
>  drivers/staging/lustre/lustre/include/cl_object.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

ALWAYS test build your patches, to not do so just makes maintainers
grumpy...

Remember, checkpatch is a _hint_, it's not always right.

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] staging: luster: Checkpatch Cleanup Craig Inches <craig@craiginches.com> - 2016-06-18 23:30 +0200
  Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-19 04:10 +0200
    Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup Craig Inches <xayto@xayto.net> - 2016-06-19 22:00 +0200

csiph-web