Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1423572
| From | Minchan Kim <minchan@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] zram: update zram to use zpool |
| Date | 2016-06-16 01:20 +0200 |
| Message-ID | <rKsgh-wr-1@gated-at.bofh.it> (permalink) |
| References | <rKkiJ-3Lp-3@gated-at.bofh.it> <rKkiJ-3Lp-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jun 15, 2016 at 10:42:07PM +0800, Geliang Tang wrote: > Change zram to use the zpool api instead of directly using zsmalloc. > The zpool api doesn't have zs_compact() and zs_pool_stats() functions. > I did the following two things to fix it. > 1) I replace zs_compact() with zpool_shrink(), use zpool_shrink() to > call zs_compact() in zsmalloc. > 2) The 'pages_compacted' attribute is showed in zram by calling > zs_pool_stats(). So in order not to call zs_pool_state() I move the > attribute to zsmalloc. > > Signed-off-by: Geliang Tang <geliangtang@gmail.com> NACK. I already explained why. http://lkml.kernel.org/r/20160609013411.GA29779@bbox
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] zram: update zram to use zpool Geliang Tang <geliangtang@gmail.com> - 2016-06-15 16:50 +0200
Re: [PATCH] zram: update zram to use zpool Dan Streetman <dan.streetman@canonical.com> - 2016-06-15 17:00 +0200
Re: [PATCH] zram: update zram to use zpool Minchan Kim <minchan@kernel.org> - 2016-06-16 01:20 +0200
Re: [PATCH] zram: update zram to use zpool Vitaly Wool <vitalywool@gmail.com> - 2016-06-17 10:40 +0200
Re: [PATCH] zram: update zram to use zpool "Austin S. Hemmelgarn" <ahferroin7@gmail.com> - 2016-06-17 14:30 +0200
Re: [PATCH] zram: update zram to use zpool Minchan Kim <minchan@kernel.org> - 2016-06-20 10:10 +0200
csiph-web