Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424809

Re: [PATCH] zram: update zram to use zpool

Show all headers | View raw

Hi Minchan,

On Thu, Jun 16, 2016 at 1:17 AM, Minchan Kim <minchan@kernel.org> wrote:
> On Wed, Jun 15, 2016 at 10:42:07PM +0800, Geliang Tang wrote:
>> Change zram to use the zpool api instead of directly using zsmalloc.
>> The zpool api doesn't have zs_compact() and zs_pool_stats() functions.
>> I did the following two things to fix it.
>> 1) I replace zs_compact() with zpool_shrink(), use zpool_shrink() to
>>    call zs_compact() in zsmalloc.
>> 2) The 'pages_compacted' attribute is showed in zram by calling
>>    zs_pool_stats(). So in order not to call zs_pool_state() I move the
>>    attribute to zsmalloc.
>>
>> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
>
> NACK.
>
> I already explained why.
> http://lkml.kernel.org/r/20160609013411.GA29779@bbox

This is a fair statement, to a certain extent. I'll let Geliang speak
for himself but I am personally interested in this zram extension
because I want it to work on MMU-less systems. zsmalloc can not handle
that, so I want to be able to use zram over z3fold.

Best regards,
   Vitaly

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] zram: update zram to use zpool Geliang Tang <geliangtang@gmail.com> - 2016-06-15 16:50 +0200
  Re: [PATCH] zram: update zram to use zpool Dan Streetman <dan.streetman@canonical.com> - 2016-06-15 17:00 +0200
  Re: [PATCH] zram: update zram to use zpool Minchan Kim <minchan@kernel.org> - 2016-06-16 01:20 +0200
    Re: [PATCH] zram: update zram to use zpool Vitaly Wool <vitalywool@gmail.com> - 2016-06-17 10:40 +0200
      Re: [PATCH] zram: update zram to use zpool "Austin S. Hemmelgarn" <ahferroin7@gmail.com> - 2016-06-17 14:30 +0200
      Re: [PATCH] zram: update zram to use zpool Minchan Kim <minchan@kernel.org> - 2016-06-20 10:10 +0200

csiph-web