Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1259889

Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode

From Vinod Koul <vinod.koul@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode
Date 2015-10-31 02:40 +0100
Message-ID <qptjb-4SL-1@gated-at.bofh.it> (permalink)
References <qokL0-2rO-19@gated-at.bofh.it> <qolQK-37m-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Oct 27, 2015 at 05:05:35PM -0500, Han Xu wrote:
>  
> -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma)
> +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma)

This change seems unrelated to patch description, can you explain why?

> +#ifdef CONFIG_PM_SLEEP
> +static int mxs_dma_pm_resume(struct device *dev)
> +{
> +	struct mxs_dma_engine *mxs_dma = dev_get_drvdata(dev);
> +	int ret;
> +
> +	ret = mxs_dma_init(mxs_dma);
> +	if (ret)
> +		return ret;
> +	return 0;

why not return mxs_dma_init() then!

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v7 0/7] mtd: nand: gpmi: gpmi-nand DSM and bitflip support Han Xu <b45815@freescale.com> - 2015-10-27 23:20 +0100
  Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode Fabio Estevam <festevam@gmail.com> - 2015-10-28 00:30 +0100
  Re: [PATCH v7 3/7] dmaengine: mxs: add i.MX7D APBH DMA support Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-29 22:10 +0100
    Re: [PATCH v7 3/7] dmaengine: mxs: add i.MX7D APBH DMA support Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-29 22:20 +0100
  Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode Vinod Koul <vinod.koul@intel.com> - 2015-10-31 02:40 +0100
    Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep  mode Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-11-02 16:30 +0100
      Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode' Vinod Koul <vinod.koul@intel.com> - 2015-11-02 16:50 +0100

csiph-web