Re: [PATCH v7 3/7] dmaengine: mxs: add i.MX7D APBH DMA support

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 3/7] dmaengine: mxs: add i.MX7D APBH DMA support
Date	2015-10-29 22:20 +0100
Message-ID	<qp2M2-5rW-9@gated-at.bofh.it> (permalink)
References	<qokL0-2rO-19@gated-at.bofh.it> <qp2Cl-5oO-5@gated-at.bofh.it> <qp2Cl-5oO-3@gated-at.bofh.it> <qp2M2-5rW-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Oct 29, 2015 at 11:03 PM, Han Xu <han.xu@freescale.com> wrote:
> On Thu, Oct 29, 2015 at 11:08:10PM +0200, Andy Shevchenko wrote:
>> On Wed, Oct 28, 2015 at 12:05 AM, Han Xu <b45815@freescale.com> wrote:
>> > From: Adrian Alonso <aalonso@freescale.com>
>> >
>> > supports APBH DMA on i.MX7D by add extra clock clk_io
>>
>> []
>>
>> >  MODULE_DEVICE_TABLE(of, mxs_dma_dt_ids);
>> > @@ -440,6 +448,13 @@ static int mxs_dma_alloc_chan_resources(struct dma_chan *chan)
>> >         if (ret)
>> >                 goto err_clk;
>> >
>> > +       /* enable the extra clk_io clock for i.MX7D */
>> > +       if (mxs_dma->dev_id == IMX7D_DMA) {
>> > +               ret = clk_prepare_enable(mxs_dma->clk_io);
>> > +               if (ret)
>> > +                       goto err_clk_unprepare;
>>
>> Perhaps err_clk.
>>
> it is err_clk_unprepare

Ah, you are right.

>> > +       }
>> > +
>> >         mxs_dma_reset_chan(chan);
>> >
>> >         dma_async_tx_descriptor_init(&mxs_chan->desc, chan);
>> > @@ -450,6 +465,8 @@ static int mxs_dma_alloc_chan_resources(struct dma_chan *chan)
>> >
>> >         return 0;
>> >
>> > +err_clk_unprepare:
>> > +       clk_disable_unprepare(mxs_dma->clk);
>> >  err_clk:
>> >         free_irq(mxs_chan->chan_irq, mxs_dma);


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v7 0/7] mtd: nand: gpmi: gpmi-nand DSM and bitflip support Han Xu <b45815@freescale.com> - 2015-10-27 23:20 +0100
  Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode Fabio Estevam <festevam@gmail.com> - 2015-10-28 00:30 +0100
  Re: [PATCH v7 3/7] dmaengine: mxs: add i.MX7D APBH DMA support Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-29 22:10 +0100
    Re: [PATCH v7 3/7] dmaengine: mxs: add i.MX7D APBH DMA support Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-29 22:20 +0100
  Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode Vinod Koul <vinod.koul@intel.com> - 2015-10-31 02:40 +0100

csiph-web