Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode
Date	Sat, 31 Oct 2015 02:40:01 +0100
Message-ID	<qptjb-4SL-1@gated-at.bofh.it> (permalink)
References	<qokL0-2rO-19@gated-at.bofh.it> <qolQK-37m-15@gated-at.bofh.it>
X-Original-To	Han Xu <b45815@freescale.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.20,221,1444719600"; d="scan'208";a="808047845"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	shijie.huang@arm.com, dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, fabio.estevam@freescale.com, hofrat@osadl.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, dan.j.williams@intel.com, dmaengine@vger.kernel.org
X-Original-Date	Sat, 31 Oct 2015 07:12:44 +0530
X-Original-Message-ID	<20151031014244.GF21326@localhost>
X-Original-References	<1445983540-27155-1-git-send-email-b45815@freescale.com> <1445983540-27155-3-git-send-email-b45815@freescale.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1259889

Show key headers only | View raw

On Tue, Oct 27, 2015 at 05:05:35PM -0500, Han Xu wrote:
>  
> -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma)
> +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma)

This change seems unrelated to patch description, can you explain why?

> +#ifdef CONFIG_PM_SLEEP
> +static int mxs_dma_pm_resume(struct device *dev)
> +{
> +	struct mxs_dma_engine *mxs_dma = dev_get_drvdata(dev);
> +	int ret;
> +
> +	ret = mxs_dma_init(mxs_dma);
> +	if (ret)
> +		return ret;
> +	return 0;

why not return mxs_dma_init() then!

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v7 0/7] mtd: nand: gpmi: gpmi-nand DSM and bitflip support Han Xu <b45815@freescale.com> - 2015-10-27 23:20 +0100
  Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode Fabio Estevam <festevam@gmail.com> - 2015-10-28 00:30 +0100
  Re: [PATCH v7 3/7] dmaengine: mxs: add i.MX7D APBH DMA support Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-29 22:10 +0100
    Re: [PATCH v7 3/7] dmaengine: mxs: add i.MX7D APBH DMA support Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-29 22:20 +0100
  Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode Vinod Koul <vinod.koul@intel.com> - 2015-10-31 02:40 +0100
    Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep  mode Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-11-02 16:30 +0100
      Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode' Vinod Koul <vinod.koul@intel.com> - 2015-11-02 16:50 +0100

csiph-web