Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode

From	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode
Date	2015-11-02 16:30 +0100
Message-ID	<qqpdv-6XC-1@gated-at.bofh.it> (permalink)
References	<qokL0-2rO-19@gated-at.bofh.it> <qolQK-37m-15@gated-at.bofh.it> <qptjb-4SL-1@gated-at.bofh.it>
Organization	Free Electrons

Show all headers | View raw

Vinod,

On Sat, 31 Oct 2015 07:12:44 +0530, Vinod Koul wrote:
> On Tue, Oct 27, 2015 at 05:05:35PM -0500, Han Xu wrote:
> >  
> > -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma)
> > +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma)
> 
> This change seems unrelated to patch description, can you explain why?

It seems related: mxs_dma_init() is now no longer called at
initialization time, but also when resuming, as visible...

> 
> > +#ifdef CONFIG_PM_SLEEP
> > +static int mxs_dma_pm_resume(struct device *dev)
> > +{
> > +	struct mxs_dma_engine *mxs_dma = dev_get_drvdata(dev);
> > +	int ret;
> > +
> > +	ret = mxs_dma_init(mxs_dma);

... here.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep  mode Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-11-02 16:30 +0100
  Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode' Vinod Koul <vinod.koul@intel.com> - 2015-11-02 16:50 +0100

csiph-web