Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14560

Re: review for pipenv/2022.10.12-1

Show all headers | View raw

> I did just notice the upstream release contains several other files
> worth considering for removal: a bunch of windows executables [1].

I agree and can remove those from the source tarball too. To do that
with the current upstream version in salsa though requires me to git
reset, re-import the 2022.10.25+ds upstream with updated
Files-Excluded, then add back the other commits. I have done that
locally but this requires a force push which is not allowed for the
debian branch since it is protected.

Alternatively I can keep the existing upstream import (which only
excludes get-pipenv.py and not the *.exe files) and add the new
excluded files in debian/copyright for the next upstream import.
Please let me know your preference on these repack options, and I will
update accordingly.

> Lintian seems to think the source for some html file is missing, but
> at first glance that hit may well be a false positive triggered by
> some bits of javascript.

> Unrelated to any of the above, I pushed some minor changes and
> enabled the CI on salsa.

Thanks! I noticed the false positive and since the lintian test on the
pipeline fails, I will add a lintian-overrides file so that it can
pass. I have not pushed that to salsa yet, but I will after hearing
your preference with the repack.

Ileana

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-22 19:40 +0200
  Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-26 16:50 +0200
    Re: review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-27 19:20 +0200
      Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-28 16:10 +0200
        Re: review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-29 09:30 +0200
          Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-31 15:50 +0100
  Re: review for pipenv/2022.10.12-1 Bastian Venthur <venthur@debian.org> - 2022-10-28 18:20 +0200

csiph-web