Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14560

Re: review for pipenv/2022.10.12-1

Path csiph.com!1.us.feeder.erje.net!3.eu.feeder.erje.net!feeder.erje.net!weretis.net!feeder8.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Ileana Dumitrescu <ileanadumitrescu95@gmail.com>
Newsgroups linux.debian.maint.python
Subject Re: review for pipenv/2022.10.12-1
Date Fri, 28 Oct 2022 16:10:02 +0200
Message-ID <FlydA-hjOJ-5@gated-at.bofh.it> (permalink)
References <FjqDv-fZP8-1@gated-at.bofh.it> <FkPTb-gRY4-5@gated-at.bofh.it> <FleHT-h7II-1@gated-at.bofh.it>
X-Original-To Jeroen Ploemen <jcfp@debian.org>
X-Mailbox-Line From debian-python-request@lists.debian.org Fri Oct 28 14:03:12 2022
Old-Return-Path <ileanadumitrescu95@gmail.com>
X-Amavis-Spam-Status No, score=-1.949 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=no autolearn_force=no
X-Policyd-Weight NOT_IN_SBL_XBL_SPAMHAUS=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .gmail. - helo: .mail-qt1-x831.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -5.5
X-Gm-Message-State ACrzQf0PQ+NKSn6tDB75HgKKYUiWX4091j9W+ik1DitcW3il1OCCVYOC GSN4QTFSy3GL9+7TlVGXtqZjEV3ABSxJNOHfE6s=
X-Google-SMTP-Source AMsMyM7DcFemK5DPGeODMn61wZiH+eP1YqsfP6mfjC8kYpMbNi5KVra8nQZ01phxBTdDA0D2au2cFjgMilPpbcOgP34=
X-Received by 2002:a05:622a:198e:b0:39c:e98c:d3e1 with SMTP id u14-20020a05622a198e00b0039ce98cd3e1mr44901787qtc.378.1666964823189; Fri, 28 Oct 2022 06:47:03 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset="UTF-8"
X-Mailing-List <debian-python@lists.debian.org> archive/latest/20412
List-ID <debian-python.lists.debian.org>
List-URL <https://lists.debian.org/debian-python/>
List-Archive https://lists.debian.org/msgid-search/CAOJuXaMjA5ZFytgo+UKaXBng97S_kid6T+_ZGkseNHw=nyF1-Q@mail.gmail.com
Approved robomod@news.nic.it
Lines 29
Organization linux.* mail to news gateway
Sender robomod@news.nic.it
X-Original-Cc debian-python <debian-python@lists.debian.org>
X-Original-Date Fri, 28 Oct 2022 16:46:51 +0300
X-Original-Message-ID <CAOJuXaMjA5ZFytgo+UKaXBng97S_kid6T+_ZGkseNHw=nyF1-Q@mail.gmail.com>
X-Original-References <20221022193344.418fa99e@debian.org> <CAOJuXaPGVe-t+59U-6T8JRbGmriZsrXog=ku=0UFBmXv4gYvWQ@mail.gmail.com> <20221027191728.098728e4@debian.org>
Xref csiph.com linux.debian.maint.python:14560

Show key headers only | View raw

> I did just notice the upstream release contains several other files
> worth considering for removal: a bunch of windows executables [1].

I agree and can remove those from the source tarball too. To do that
with the current upstream version in salsa though requires me to git
reset, re-import the 2022.10.25+ds upstream with updated
Files-Excluded, then add back the other commits. I have done that
locally but this requires a force push which is not allowed for the
debian branch since it is protected.

Alternatively I can keep the existing upstream import (which only
excludes get-pipenv.py and not the *.exe files) and add the new
excluded files in debian/copyright for the next upstream import.
Please let me know your preference on these repack options, and I will
update accordingly.

> Lintian seems to think the source for some html file is missing, but
> at first glance that hit may well be a false positive triggered by
> some bits of javascript.

> Unrelated to any of the above, I pushed some minor changes and
> enabled the CI on salsa.

Thanks! I noticed the false positive and since the lintian test on the
pipeline fails, I will add a lintian-overrides file so that it can
pass. I have not pushed that to salsa yet, but I will after hearing
your preference with the repack.

Ileana

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-22 19:40 +0200
  Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-26 16:50 +0200
    Re: review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-27 19:20 +0200
      Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-28 16:10 +0200
        Re: review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-29 09:30 +0200
          Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-31 15:50 +0100
  Re: review for pipenv/2022.10.12-1 Bastian Venthur <venthur@debian.org> - 2022-10-28 18:20 +0200

csiph-web