Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14552

review for pipenv/2022.10.12-1

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

hi Ileana,

I took a look at the package update you prepared and put up for
sponsorship in the Python team:

* leftover boilerplate comments and examples remain throughout the
  packaging (control, rules, watch), please remove when unused.
* changelog: isn't #941447 also fixed by the new release? See
  upstream's comment on https://github.com/pypa/pipenv/issues/4144
* copyright:
  + packaging year bumped for venthur@debian.org but his last
    involvement actually does appear to have been in 2018; you
    probably want to add yourself instead with a 2022 entry?
  + `grep -irn --exclude-dir=debian 'copyr.*\(19\|20\)[0-9]\{2\}' *`
    turns up numerous copyright holders that are missing from
    d/copyright.
* watch: filenamemangle introduces literal "<project>" string into
  the filename.
* lintian:
  + numerous hits for 'extra-license-file' and
    'package-contains-documentation-outside-usr-share-doc', triggered
    by license and readme files inside vendored libs; these files
    could easily be removed during build.
  + E: pipenv: python-traceback-in-manpage is a false positive,
    please override.


PS: I'm kind of surprised a package with this amount of vendoring
managed to survive the ftp masters' review. Apparently, sometimes
miracles do happen.

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-22 19:40 +0200
  Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-26 16:50 +0200
    Re: review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-27 19:20 +0200
      Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-28 16:10 +0200
        Re: review for pipenv/2022.10.12-1 Jeroen Ploemen <jcfp@debian.org> - 2022-10-29 09:30 +0200
          Re: review for pipenv/2022.10.12-1 Ileana Dumitrescu <ileanadumitrescu95@gmail.com> - 2022-10-31 15:50 +0100
  Re: review for pipenv/2022.10.12-1 Bastian Venthur <venthur@debian.org> - 2022-10-28 18:20 +0200

csiph-web