Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1664607 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-13 11:00 +0200 |
| Last post | 2017-06-13 12:50 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" Colin King <colin.king@canonical.com> - 2017-06-13 11:00 +0200
Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" Joe Perches <joe@perches.com> - 2017-06-13 12:40 +0200
Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" Colin Ian King <colin.king@canonical.com> - 2017-06-13 12:50 +0200
Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" Joe Perches <joe@perches.com> - 2017-06-13 12:50 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-13 11:00 +0200 |
| Subject | [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" |
| Message-ID | <tRPQ5-5MF-7@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com> Trivial fix to spelling mistake in seq_printf message Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/crypto/cavium/nitrox/nitrox_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c index eee6fb501580..ae44a464cd2d 100644 --- a/drivers/crypto/cavium/nitrox/nitrox_main.c +++ b/drivers/crypto/cavium/nitrox/nitrox_main.c @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v) struct nitrox_device *ndev = s->private; seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx); - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id); + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id); seq_printf(s, " Cores [AE: %u SE: %u]\n", ndev->hw.ae_cores, ndev->hw.se_cores); seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues); -- 2.11.0
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-06-13 12:40 +0200 |
| Subject | Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" |
| Message-ID | <tRRoS-6Pq-17@gated-at.bofh.it> |
| In reply to | #1664607 |
On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Trivial fix to spelling mistake in seq_printf message Hey Colin. Fixing spelling typos is a good thing, but is it a good thing to change possibly API dependent output in seq_ calls? > diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c [] > @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v) > struct nitrox_device *ndev = s->private; > > seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx); > - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id); > + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id); > seq_printf(s, " Cores [AE: %u SE: %u]\n", > ndev->hw.ae_cores, ndev->hw.se_cores); > seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);
[toc] | [prev] | [next] | [standalone]
| From | Colin Ian King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-13 12:50 +0200 |
| Subject | Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" |
| Message-ID | <tRRyx-6SG-9@gated-at.bofh.it> |
| In reply to | #1664731 |
On 13/06/17 11:36, Joe Perches wrote: > On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Trivial fix to spelling mistake in seq_printf message > > Hey Colin. > > Fixing spelling typos is a good thing, but is it a > good thing to change possibly API dependent output > in seq_ calls? Considering it's in -next and has not landed in upstream I supposed it was better to fix it now before it landed in Linus' repo. Colin > >> diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c > [] >> @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v) >> struct nitrox_device *ndev = s->private; >> >> seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx); >> - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id); >> + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id); >> seq_printf(s, " Cores [AE: %u SE: %u]\n", >> ndev->hw.ae_cores, ndev->hw.se_cores); >> seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues); > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-06-13 12:50 +0200 |
| Subject | Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" |
| Message-ID | <tRRyy-6SG-15@gated-at.bofh.it> |
| In reply to | #1664740 |
On Tue, 2017-06-13 at 11:40 +0100, Colin Ian King wrote: > On 13/06/17 11:36, Joe Perches wrote: > > On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote: > > > From: Colin Ian King <colin.king@canonical.com> > > > > > > Trivial fix to spelling mistake in seq_printf message > > Fixing spelling typos is a good thing, but is it a > > good thing to change possibly API dependent output > > in seq_ calls? > Considering it's in -next and has not landed in upstream I supposed it > was better to fix it now before it landed in Linus' repo. Good call, thanks. > > > diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c > > > > [] > > > @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v) > > > struct nitrox_device *ndev = s->private; > > > > > > seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx); > > > - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id); > > > + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id); > > > seq_printf(s, " Cores [AE: %u SE: %u]\n", > > > ndev->hw.ae_cores, ndev->hw.se_cores); > > > seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web