Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664731

Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"

Show all headers | View raw

On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to spelling mistake in seq_printf message

Hey Colin.

Fixing spelling typos is a good thing, but is it a
good thing to change possibly API dependent output
in seq_ calls?

> diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
[]
> @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v)
>  	struct nitrox_device *ndev = s->private;
>  
>  	seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx);
> -	seq_printf(s, "  Revsion ID: 0x%0x\n", ndev->hw.revision_id);
> +	seq_printf(s, "  Revision ID: 0x%0x\n", ndev->hw.revision_id);
>  	seq_printf(s, "  Cores [AE: %u  SE: %u]\n",
>  		   ndev->hw.ae_cores, ndev->hw.se_cores);
>  	seq_printf(s, "  Number of Queues: %u\n", ndev->nr_queues);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" Colin King <colin.king@canonical.com> - 2017-06-13 11:00 +0200
  Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake  "Revsion" -> "Revision" Joe Perches <joe@perches.com> - 2017-06-13 12:40 +0200
    Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake  "Revsion" -> "Revision" Colin Ian King <colin.king@canonical.com> - 2017-06-13 12:50 +0200
      Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake  "Revsion" -> "Revision" Joe Perches <joe@perches.com> - 2017-06-13 12:50 +0200

csiph-web